-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When moving the "pop-out" settings window into a tab, both this window and the rule entry created for the highlighted word are duplicated. #30
Comments
Hello, Regarding the number 3, that one is the most tricky. Currently it shows all rules that have "each word" option active (so that the new word can be added there). |
Hi, thanks for the reply! The "each word" option requirement makes sense – now I realize that I'm only seeing a handful of choices because virtually all of my rules are using a simple regex. Makes sense! It's a minor thing so no big deal. As an aside, would it be possible for some form or organization for rules? Like grouping by site, or nested entries by site, something along those lines? This has quickly become my most used extension and it's becoming a bit difficult to keep track of all my rules :) Anyhow, thanks for a great extension, it's truly useful! |
Yeah, grouping is planned feature for some time now. It's bothering me a lot too. |
Even one level deep would be great, it's enough to reduce the visual overload and would make it much easier to visually find certain rules. In fact, I'd even prefer getting that feature over any of the issues I mentioned in my original bug report! Hopefully it's not too complicated and can be done. I've been suggesting this extension to friends and everyone agrees how useful it is, I really hope you continue to develop it :) |
Describe the bug
ISSUES: (3 separate ones)
The "pop-out" settings window (the one that appears after highlighting a word and selecting a context-menu option, not the "pop-up" from the toolbar icon) has an arrow at the top-right corner that allows you to move it to a tab. When clicked, the pop-out window is cloned to a tab instead of being moved itself, which means there are now 2 settings windows (the original pop-out (still on the original page), and the newly created tab) and 2 new rule entries created.
When the "Always open in new tab - when clicking toolbar icon" setting is enabled, clicking the toolbar icon does nothing. It does not open settings in a new tab, nor does it show the toolbar pop-up. Disabling the checkbox for this option immediately allows the toolbar pop-up to appear.
When selecting the "Add to existing rule" context-menu option, only 3-4 seemingly random choices appear. The available choices don't appear to have anything to do with the current website, and it's definitely not chronological. Could this be fixed to show all available rules that already exist for the current website?
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
Upon clicking on the arrow, I'd expect the original settings pop-out to itself be moved to a tab, rather than a new instance of it cloned to tab. Also, I would not expect a second identical rule entry being created. Any rule changes / options selected in either window will also immediately show up in the other, in case that matters.
Presumably, the normal/intended behavior would for the original settings pop-out window itself be moved to a tab, or at least closed when the new tab is created. Also, there should not be 2 new rule entries created.
Device info:
Additional info
I wasn't sure if I was supposed to create 3 new bug reports; I went with 1 because I assumed it would be less spammy and the 2nd/3rd problem(s) are minor. I apologize if there's an issue with this.
The text was updated successfully, but these errors were encountered: