FAI-8527 - Fix config redaction when one-letter filenames are present #87
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjwooo
requested review from
tovbinm,
ypc-faros and
willmarks
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
willmarks
approved these changes
Nov 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a file exists whose name is exactly one letter where that letter is in one of the config paths to redact, bash replaces the path string with that letter when assigning the output of this jq expression to an array variable. No idea why it does this.
Type of change
Related issues
Migration notes
Extra info