-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move delete dialog to App.vue #459
Comments
See #190 (comment). It might be better to just wait and treat this along with merge conflicts, as well as error handling (#428) for that matter, all beta milestone issues. |
As I mentioned in the comments of the
That should resolve the main concerns of this issue, namely decoupling that logic from the Tasks module. The remaining concerns around deleting entities can be tracked in #411, primarily, and to a lesser extent in #284. |
Right now the delete dialog and its associated state and methods are in
Tasks.vue
. This seems like a good feature to move to core, since the behavior should be consistent across Field Modules. I'd like to first move the markup, state, methods, and custom events toApp.vue
, then work out a way to embed this process directly into the delete Vuex actions, so the events don't have to be fired manually with each corresponding deletion. It would also be good UX, imo, to enforce this warning for all delete actions.A corollary to this issue is having some kind of general handling of modals in
App.vue
, but that can be developed later.The text was updated successfully, but these errors were encountered: