Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move delete dialog to App.vue #459

Closed
jgaehring opened this issue Sep 23, 2021 · 2 comments
Closed

Move delete dialog to App.vue #459

jgaehring opened this issue Sep 23, 2021 · 2 comments

Comments

@jgaehring
Copy link
Member

Right now the delete dialog and its associated state and methods are in Tasks.vue. This seems like a good feature to move to core, since the behavior should be consistent across Field Modules. I'd like to first move the markup, state, methods, and custom events to App.vue, then work out a way to embed this process directly into the delete Vuex actions, so the events don't have to be fired manually with each corresponding deletion. It would also be good UX, imo, to enforce this warning for all delete actions.

A corollary to this issue is having some kind of general handling of modals in App.vue, but that can be developed later.

@jgaehring
Copy link
Member Author

See #190 (comment).

It might be better to just wait and treat this along with merge conflicts, as well as error handling (#428) for that matter, all beta milestone issues.

@jgaehring
Copy link
Member Author

As I mentioned in the comments of the AppModal.vue, via c30cd8e:

This is just a fast & cheap way of temporarily stashing the delete dialog,
previously embedded in the Tasks container component, here in AppModal, which
itself is no longer needed since the drawer has its own implementation, as of
the previous commit. Eventually, this should become a special component, akin
to AppBar or AppDrawer, whose state is managed by AppShell, which itself can
provide a method to all field modules for triggering a modal dialog. One
instance of this will be the delete dialog, which AppShell can trigger auto-
matically whenever a deletion is performed.

That should resolve the main concerns of this issue, namely decoupling that logic from the Tasks module. The remaining concerns around deleting entities can be tracked in #411, primarily, and to a lesser extent in #284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant