Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TasksFilter using new loadLogs action #398

Closed
jgaehring opened this issue Aug 27, 2020 · 2 comments
Closed

Refactor TasksFilter using new loadLogs action #398

jgaehring opened this issue Aug 27, 2020 · 2 comments

Comments

@jgaehring
Copy link
Member

It seems a bit redundant having an entirely separate filtering implementation now that we have filters built in to how the loadLogs action works.

The main benefit of refactoring would just be the elimination of unnecessary code, but a side effect would be that if the user had a filtered view and hit sync, it would only sync the logs currently in view. I want to say that is a feature, and not a drawback, right?

@jgaehring jgaehring added this to the 0.8.0: Component Library milestone Aug 27, 2020
@jgaehring jgaehring changed the title Refactor FilterLogs using new loadLogs action Refactor TasksFilter using new loadLogs action Jul 12, 2021
@jgaehring
Copy link
Member Author

I'm going to get rid of the current date options (eg, "Today", "This Week", "All Time", etc) in this component, at least for the time being. I really like the ergonomics those options affords, but it's always been a little lacking, like when you want to have this week's logs but also the next day's logs. I think this will be remedied by #423, but for the time being, I'm just going to revert to using two FarmDateTimeForm components to set the range explicitly.

@jgaehring
Copy link
Member Author

for the time being, I'm just going to revert to using two FarmDateTimeForm components to set the range explicitly.

I'm think I'm going to forgo the date filters altogether for now, and just wait til I can sort logs by time (#399). We already have caching criteria that should provide some limits. I believe if at that time I add some sensible, hardcoded time limits for the how far back to include logs in the "Done" category, and how far forward for the "Upcoming" category, it will obviate the need for this type of filter.

jgaehring added a commit to jgaehring/field-kit that referenced this issue Sep 23, 2021
jgaehring added a commit to jgaehring/field-kit that referenced this issue Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant