Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: barThickness is mandatory, charts break if not supplied #7

Open
MBlistein opened this issue Mar 21, 2018 · 1 comment
Open

Bug: barThickness is mandatory, charts break if not supplied #7

MBlistein opened this issue Mar 21, 2018 · 1 comment

Comments

@MBlistein
Copy link

Usually the barThickness is an optional value. I would prefer to not use it, since this static value has significant disadvantages when displaying charts of different size screens.
However, when removing it in the current code, the entire chart fails.

@fanthos
Copy link
Owner

fanthos commented Mar 23, 2018

I think the barThinkness should be reimplemented as barMaxThinkness.

Currently the chart can be resized by external code. ref: home-assistant
Just use the code after creating the chart with setTimeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants