{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":5910539,"defaultBranch":"master","name":"bitcoin","ownerLogin":"fanquake","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2012-09-22T05:28:42.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/863730?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1726737905.0","currentOid":""},"activityList":{"items":[{"before":"197aa249551ea7b2280b6e187d2ad5378687beff","after":"79f20fa1b1ec1a0c7fc0017f3d0e15aad75a7658","ref":"refs/heads/master","pushedAt":"2024-09-20T15:05:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30561: refactor: move `SignSignature` helpers to test utils\n\n58499b00d0ad1c83e433caa8fcc0e5d3fd3f2070 refactor: move `SignSignature` helpers to test utils (Sebastian Falbesoner)\n\nPull request description:\n\n  These helpers haven't been used in production code since segwit was merged more than eight years ago (see commit 605e8473, PR #8149), so it seems appropriate to move them to the test utils module. As suggested by instagibbs, see https://github.com/bitcoin/bitcoin/pull/30352#discussion_r1697515508.\n\nACKs for top commit:\n  instagibbs:\n     ACK 58499b00d0ad1c83e433caa8fcc0e5d3fd3f2070\n  pablomartin4btc:\n    ACK 58499b00d0ad1c83e433caa8fcc0e5d3fd3f2070\n\nTree-SHA512: a52d3b92b477246f2ceb57c3690d0229a492b65a15dae331faeae9d96e5907f7fe1176edc1530243e0f088586984fd7ba435a0a2d2f2531c04d076fdf3f4095f","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2440105958\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30561\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30561/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30561\">bitcoin#30561</a>: refactor: move <code>SignSignature</code> helpers to test u…"}},{"before":"6fa8cd0c8a3b895569662429482b1a38b5cd51b9","after":"64276c7519bb9721c930c403f357e5866719454e","ref":"refs/heads/guix_latest","pushedAt":"2024-09-20T10:03:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"[WIP] guix: update to e9d903f146865db5948abd271a5c7e763681b4e9\n\nCurrently, this causes atleast the riscv64 build to fail. glibc fails to\nbuild with the new binutils (2.41).\n\nPackage updates:\nfile 5.44 -> 5.45\n(base) glibc 2.35 -> 2.39\ngrep 3.8 -> 3.11\ndiffutils 3.8 -> 3.10\ngawk 5.2.1 -> 5.3.0\ngzip 1.12 -> 1.13\nxz 5.2.8 -> 5.4.5\nmake 4.3 -> 4.4.1\nbinutils 2.38 -> 2.41\nlinux-headers 6.1.106 -> 6.1.109\n\nCMake-3.30 becomes available.","shortMessageHtmlLink":"[WIP] guix: update to e9d903f146865db5948abd271a5c7e763681b4e9"}},{"before":"84cd6478c422bc296589ab031f5c76e7bab2704d","after":"197aa249551ea7b2280b6e187d2ad5378687beff","ref":"refs/heads/master","pushedAt":"2024-09-20T10:00:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30856: build: drop obj/ subdirectory for generated build.h\n\n7025942687fd5e91d0a10ce5b2ac673b67a63491 build: drop superfluous `HAVE_BUILD_INFO` define (Sebastian Falbesoner)\n0dd662510c52b202f7136fbcb32ed3864b52b50b build: drop obj/ subdir for generated build.h, rename to bitcoin-build-info.h (Sebastian Falbesoner)\n\nPull request description:\n\n  As indicated by the TODO, the obj subdirectory is not needed anymore now for the generated build.h header, since autotools are gone and we don't have in-source builds anymore (see #30454, #30664). In the second commit the superflous `HAVE_BUILD_INFO` macro is dropped, as suggested in https://github.com/bitcoin/bitcoin/pull/30856#pullrequestreview-2292424496.\n\nACKs for top commit:\n  theuni:\n    utACK 7025942687fd5e91d0a10ce5b2ac673b67a63491\n\nTree-SHA512: 0a3b2cbbcf638344ceb74e5ba5a0fe2b1718427b23a18c8890258db36ce7177006a146178ed88d9c5ae956a5426f3844e86c1f4cca7c40946359742bffda983b","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2514999697\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30856\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30856/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30856\">bitcoin#30856</a>: build: drop obj/ subdirectory for generated build.h"}},{"before":"63ce8460c216faf8396b8fb15d8e314cd4f8fc63","after":"175475112417f657dc15ccfe51325c5f8bb82ace","ref":"refs/heads/gcc_13_v2","pushedAt":"2024-09-19T15:46:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"[WIP] ci: use GCC 13 for some jobs","shortMessageHtmlLink":"[WIP] ci: use GCC 13 for some jobs"}},{"before":"2db926f49c812a3f04a565834c841ce4bc4ae288","after":"84cd6478c422bc296589ab031f5c76e7bab2704d","ref":"refs/heads/master","pushedAt":"2024-09-19T15:44:29.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30927: Follow-up after AutoFile position caching: remove unused code\n\ncaac06f784c5d94c6a5f7d0b586f9ddbbe55c369 streams: reorder/document functions (Pieter Wuille)\n67a3d590768301fb46a93fdb0a5c66c0c2de1082 streams: remove unused code (Pieter Wuille)\n\nPull request description:\n\n  This is a follow-up to #30884.\n\n  Remove a number of dead code paths, and improve the code organization and documentation, in `AutoFile`.\n\nACKs for top commit:\n  maflcko:\n    re-ACK caac06f784c5d94c6a5f7d0b586f9ddbbe55c369\n  theStack:\n    Code-review ACK caac06f784c5d94c6a5f7d0b586f9ddbbe55c369\n  l0rinc:\n    ACK caac06f784c5d94c6a5f7d0b586f9ddbbe55c369\n  tdb3:\n    CR ACK caac06f784c5d94c6a5f7d0b586f9ddbbe55c369\n\nTree-SHA512: 297791f093e0142730f815c11dd3466b98f7e7edea86094a815dae989ef40d8056db10e0fed6e575d530903c18e80c08d36d3f1e6b828f2d955528f365b22008","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2536073168\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30927\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30927/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30927\">bitcoin#30927</a>: Follow-up after AutoFile position caching: remov…"}},{"before":"60289cd0b7e70e56535daab955c15e1f4d63221a","after":"58f0bd06483e9d4b8fdd8131e92ad884648708f5","ref":"refs/heads/fully_static_bitcoind","pushedAt":"2024-09-19T12:33:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"guix: add fortified glibc 2.40","shortMessageHtmlLink":"guix: add fortified glibc 2.40"}},{"before":"f65aa9b2f0f7feb9ad7c726d9d4e00f56eefd296","after":"60289cd0b7e70e56535daab955c15e1f4d63221a","ref":"refs/heads/fully_static_bitcoind","pushedAt":"2024-09-19T11:31:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"guix: build aarch64-linux bitcoind fully statically\n\n-static-pie\nProduce a static position independent executable on targets that support it.\nA static position independent executable is similar to a static executable,\nbut can be loaded at any address without a dynamic linker.\n\nSee https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html","shortMessageHtmlLink":"guix: build aarch64-linux bitcoind fully statically"}},{"before":"974e5ea3f265a84b5595f3d81848c84cecb6641f","after":"6fa8cd0c8a3b895569662429482b1a38b5cd51b9","ref":"refs/heads/guix_latest","pushedAt":"2024-09-19T11:25:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"[WIP] guix: update to bfdde6980834fe462b370ddb1ca0e42b22632090\n\nCurrently, this causes atleast the riscv64 build to fail. glibc fails to\nbuild with the new binutils (2.41).\n\nPackage updates:\nfile 5.44 -> 5.45\n(base) glibc 2.35 -> 2.39\ngrep 3.8 -> 3.11\ndiffutils 3.8 -> 3.10\ngawk 5.2.1 -> 5.3.0\ngzip 1.12 -> 1.13\nxz 5.2.8 -> 5.4.5\nmake 4.3 -> 4.4.1\nbinutils 2.38 -> 2.41\nlinux-headers 6.1.106 -> 6.1.109\n\nCMake-3.30 becomes available.","shortMessageHtmlLink":"[WIP] guix: update to bfdde6980834fe462b370ddb1ca0e42b22632090"}},{"before":"9ba56884f625a84dea96912bee51a16b8949c5ba","after":"2db926f49c812a3f04a565834c841ce4bc4ae288","ref":"refs/heads/master","pushedAt":"2024-09-19T11:17:43.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30889: log: Use ConstevalFormatString\n\nfacbcd4cef8890ae18976fb53b67ea56b3c04454 log: Use ConstevalFormatString (MarcoFalke)\nfae9b60c4ffef38d9725f42f992b1f38765312a3 test: Use LogPrintStr to test m_log_sourcelocations (MarcoFalke)\nfa39b1ca63874db8ef8bc16b87e2699e8e1b67be doc: move-only logging warning (MarcoFalke)\n\nPull request description:\n\n  This changes all logging (including the wallet logging) to produce a\n  `ConstevalFormatString` at compile time, so that the format string can be\n  validated at compile-time.\n\n  I tested with `clang` and found that the compiler will use less than 1% more of time and memory.\n\n  When an error is found, the compile-time error depends on the compiler, but it may look similar to:\n\n  ```\n  src/util/string.h: In function ‘int main(int, char**)’:\n  src/bitcoind.cpp:265:5:   in ‘constexpr’ expansion of ‘util::ConstevalFormatString<1>(((const char*)\"Hi %s %s\"))’\n  src/util/string.h:38:98:   in ‘constexpr’ expansion of ‘util::ConstevalFormatString<1>::Detail_CheckNumFormatSpecifiers(std::basic_string_view<char>(((const char*)((util::ConstevalFormatString<1>*)this)->util::ConstevalFormatString<1>::fmt)))’\n  src/util/string.h:78:34: error: expression ‘<throw-expression>’ is not a constant expression\n     78 |         if (num_params != count) throw \"Format specifier count must match the argument count!\";\n        |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n  ```\n\n  This refactor does not change behavior of the compiled executables.\n\nACKs for top commit:\n  hodlinator:\n    re-ACK facbcd4cef8890ae18976fb53b67ea56b3c04454\n  l0rinc:\n    ACK facbcd4cef8890ae18976fb53b67ea56b3c04454\n  ryanofsky:\n    Code review ACK facbcd4cef8890ae18976fb53b67ea56b3c04454\n  pablomartin4btc:\n    re-ACK facbcd4cef8890ae18976fb53b67ea56b3c04454\n  stickies-v:\n    Approach ACK and code LGTM facbcd4cef8890ae18976fb53b67ea56b3c04454 modulo a `tinyformat::format_error` concern.\n\nTree-SHA512: 852f74d360897020f0d0f6e5064edc5e7f7dacc2bec1d5feff22c634a2fcd2eb535aa75be0b7191d9053728be6108484c737154b02d68ad3186a2e5544ba0db8","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2523088773\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30889\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30889/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30889\">bitcoin#30889</a>: log: Use ConstevalFormatString"}},{"before":"ab0b5706b254ed914f94b41940a946d84ac8dd6d","after":"9ba56884f625a84dea96912bee51a16b8949c5ba","ref":"refs/heads/master","pushedAt":"2024-09-19T09:42:29.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30869: ci: Print inner env, Make ccache config more flexible\n\nfa99e4521b6fc0e7f6636d40bc0d6a7325227374 ci: Allow CCACHE_DIR bind mount (MarcoFalke)\nfa252da0b9cc6c7e795366ce4a1ddc4c198dff15 ci: Remove hardcoded CCACHE_DIR in cirrus (MarcoFalke)\nfa146904e19e345714fd40fd2f0fbad8118957b9 ci: Bump default CCACHE_MAXSIZE to 500M (MarcoFalke)\naaaa7cf8bad0e125a67e996162271eb26bef4fb6 cirrus: Drop CCACHE_NOHASHDIR (MarcoFalke)\nfa7ca182a9b0c65f567116b67108da14182e5338 ci: Print inner env (MarcoFalke)\n\nPull request description:\n\n  The outer env is printed when the `/tmp/env-$USER-$CONTAINER_NAME` is created. There is also a separate env printed when building the container image (usually with default values).\n\n  To confirm that the inner container env is correctly derived from the outer env, and not from the default build env, print it a third time.\n\nACKs for top commit:\n  l0rinc:\n    utACK fa99e4521b6fc0e7f6636d40bc0d6a7325227374\n  willcl-ark:\n    ACK fa99e4521b6fc0e7f6636d40bc0d6a7325227374\n\nTree-SHA512: 59fd3262d551e09224866e31c14ca865461e81abbe00b83391fe3a9c7ada30fd2fd0272e4aa812df2712433ac7594d1a55cf674248b341359cec09c8d3f0c58b","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2519424504\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30869\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30869/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30869\">bitcoin#30869</a>: ci: Print inner env, Make ccache config more fle…"}},{"before":null,"after":"01145020b035560aaa600d0f7f6c8d4d4eca8edc","ref":"refs/heads/valgrind_clang_18","pushedAt":"2024-09-19T09:25:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"ci: use clang-18 for Valgrind","shortMessageHtmlLink":"ci: use clang-18 for Valgrind"}},{"before":"e1e97220a364229cd90a34af23ec15b73e3c724f","after":"974e5ea3f265a84b5595f3d81848c84cecb6641f","ref":"refs/heads/guix_latest","pushedAt":"2024-09-19T08:46:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"[WIP] guix: update to 610b395424c02274800d85585cb542ad66d9afea\n\nCurrently, this causes atleast the riscv64 build to fail. glibc fails to\nbuild with the new binutils (2.41).\n\nPackage updates:\nfile 5.44 -> 5.45\n(base) glibc 2.35 -> 2.39\ngrep 3.8 -> 3.11\ndiffutils 3.8 -> 3.10\ngawk 5.2.1 -> 5.3.0\ngzip 1.12 -> 1.13\nxz 5.2.8 -> 5.4.5\nmake 4.3 -> 4.4.1\nbinutils 2.38 -> 2.41\nlinux-headers 6.1.106 -> 6.1.109\n\nCMake-3.30 becomes available.","shortMessageHtmlLink":"[WIP] guix: update to 610b395424c02274800d85585cb542ad66d9afea"}},{"before":"fd08fded63adb5bcda2334a98c02d653a849debb","after":"ab0b5706b254ed914f94b41940a946d84ac8dd6d","ref":"refs/heads/master","pushedAt":"2024-09-18T17:44:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30875: doc: fixed inconsistencies in documentation between autotools to cmake change\n\na9964c04447745435747d9cc557165c43902783b doc: Updating docs from autotools to cmake (kevkevinpal)\n\nPull request description:\n\n  A bit of a followup from https://github.com/bitcoin/bitcoin/pull/30840\n\n  - In this change the documentation where we refer to the `./configure` script which is now gone and have converted the configure params to use the `cmake` equivalent.\n\nACKs for top commit:\n  maflcko:\n    ACK a9964c04447745435747d9cc557165c43902783b\n  jonatack:\n    utACK a9964c04447745435747d9cc557165c43902783b\n  jarolrod:\n    ACK a9964c04447745435747d9cc557165c43902783b\n  tdb3:\n    ACK a9964c04447745435747d9cc557165c43902783b\n  pablomartin4btc:\n    re-ACK a9964c04447745435747d9cc557165c43902783b\n\nTree-SHA512: f7ed20b8ad61f028c0d242b9cc70650d8da63057d4a8f7da88f0117a8d3241c5fe8fcf19d56ec82088160b9fee9b175fe9f64e5a845260d3696dc7e94bfdd0bd","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2521033885\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30875\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30875/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30875\">bitcoin#30875</a>: doc: fixed inconsistencies in documentation betw…"}},{"before":"69409bc6e55848cf959ed924bcc722997455d76f","after":"fd08fded63adb5bcda2334a98c02d653a849debb","ref":"refs/heads/master","pushedAt":"2024-09-18T17:42:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30639: ci: Use clang-19 in msan tasks\n\nccccb67851b03a7042bbf62a5534607f174ec47b ci: Use clang-19 in msan tasks (MarcoFalke)\n\nPull request description:\n\n  A new clang version generally comes with bugfixes, new sanitizer features, deprecations, as well as new features.\n\n  Upgrade the memory sanitizer tasks to use the new version.\n\n  (Ref https://github.com/bitcoin/bitcoin/pull/30634)\n\nACKs for top commit:\n  fanquake:\n    ACK ccccb67851b03a7042bbf62a5534607f174ec47b Tested both jobs on aarch64, and one on x86_64 with `mmap_rnd_bits`.\n\nTree-SHA512: a42bf2da7c08aa54c0c5ab3811ff51b98b80b276be135eed32395a55ae93a42d41d7cd32c307062dcca711a892958ea141168c2a06025560074f8c5d20190946","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2461513165\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30639\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30639/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30639\">bitcoin#30639</a>: ci: Use clang-19 in msan tasks"}},{"before":"8ccae50bb79df0fb8f620edf39e22602e95c339e","after":"e1e97220a364229cd90a34af23ec15b73e3c724f","ref":"refs/heads/guix_latest","pushedAt":"2024-09-18T09:18:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"[WIP] guix: update to 4b7bb05c29d390fb095f7a96e83c54efa8379497\n\nCurrently, this causes atleast the riscv64 build to fail. glibc fails to\nbuild with the new binutils (2.41).\n\nPackage updates:\nfile 5.44 -> 5.45\n(base) glibc 2.35 -> 2.39\ngrep 3.8 -> 3.11\ndiffutils 3.8 -> 3.10\ngawk 5.2.1 -> 5.3.0\ngzip 1.12 -> 1.13\nxz 5.2.8 -> 5.4.5\nmake 4.3 -> 4.4.1\nbinutils 2.38 -> 2.41\nlinux-headers 6.1.106 -> 6.1.109\n\nCMake-3.30 becomes available.","shortMessageHtmlLink":"[WIP] guix: update to 4b7bb05c29d390fb095f7a96e83c54efa8379497"}},{"before":"6b97882ab53e8a7edc656eb1958eac3938e3b73d","after":"69409bc6e55848cf959ed924bcc722997455d76f","ref":"refs/heads/master","pushedAt":"2024-09-18T09:17:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30908: doc: remove Eclipser fuzzing documentation\n\n735436df8cebf28d4bcf0ad7e8f1fd7f19191001 Remove outdated Eclipser fuzzing documentation (Jon Atack)\n\nPull request description:\n\n  Remove the Eclipser fuzzing documentation from `doc/fuzzing.md`, as that repository (https://github.com/SoftSec-KAIST/Eclipser) hasn't been updated in several years, appears possibly unmaintained, and likely isn't being actively used for fuzzing Bitcoin Core.\n\n  These docs were originally added in https://github.com/bitcoin/bitcoin/pull/22585.\n\nACKs for top commit:\n  maflcko:\n    review ACK 735436df8cebf28d4bcf0ad7e8f1fd7f19191001\n  brunoerg:\n    ACK 735436df8cebf28d4bcf0ad7e8f1fd7f19191001\n\nTree-SHA512: 7ccbf93c10add53e92edf67a622722935029add63f8fbb6e733b96e9d155faeb8d5d3678adb0e7f2ce8ccbdffd2a34c3dc93adbcf4e3ce0cdd03e20ad3e6bbd6","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2528884165\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30908\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30908/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30908\">bitcoin#30908</a>: doc: remove Eclipser fuzzing documentation"}},{"before":"6fc4692797121b54de0c54e5b09ee47f322c038a","after":"6b97882ab53e8a7edc656eb1958eac3938e3b73d","ref":"refs/heads/master","pushedAt":"2024-09-18T09:16:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30915: ci: Use `ninja` to build in macOS native CI job\n\nd01b85bfecbcf16ea16f90e2ade7537bf582269f ci: Use `ninja` to build in macOS native CI job (Hennadii Stepanov)\n\nPull request description:\n\n  This PR addresses [this](https://github.com/bitcoin/bitcoin/pull/30911#issuecomment-2354922939) comment:\n  > I wonder if one CI task should be using Ninja (and cmake >= 3.27), if it isn't too hard to implement. Otherwise this config will remain untested and errors may sneak in to the master branch, only being detected after merge.\n\nACKs for top commit:\n  maflcko:\n    review ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f\n  theuni:\n    ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f.\n  jonatack:\n    ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f\n  jarolrod:\n    ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f\n\nTree-SHA512: 5cbbc87f0e48512441a4f0cf10af2f6d73f24d3e8667b338b176fd1667fd5d7739349bcede3aeef973497ff67d33cb8f7d7f3681c3ede8e8b2f673b853d5bc63","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2530997248\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30915\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30915/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30915\">bitcoin#30915</a>: ci: Use <code>ninja</code> to build in macOS native CI job"}},{"before":null,"after":"1147e72953d1f262111a4b1d5a438a8394511bc7","ref":"refs/heads/28.x","pushedAt":"2024-09-17T16:15:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30827: [28.x] Further backports and rc2\n\n06a7df70df30879e0b691d1a252636f703b8cdfb doc: Generate manpages (Ava Chow)\n5315886bf5bb430ced1b23ebfcd0b8865b523675 build: Bump to 28.0rc2 (Ava Chow)\nff95cb31da6ab6af70125b2c0b78aa976780c61e streams: remove AutoFile::Get() entirely (Pieter Wuille)\n8229e981167f61e2d4c2e8b7761cba68374ea92f streams: cache file position within AutoFile (Pieter Wuille)\n1b853fdb0a40064a5c75b2dae96dfe1d590de6e1 qt: Translations update (Hennadii Stepanov)\n674dded8756ddf9b731f3149c66dd044090e4c8e gui: fix crash when closing wallet (furszy)\nd39262e5d41e92d22e020d283ddb6e4e406647b2 test: Wait for local services to update in feature_assumeutxo (Fabian Jahr)\nb329ed739b7311b3b47cae1ef8d576a90e0a36a1 test: add coverage for assumeUTXO honest peers disconnection (furszy)\nc6b5db1d591f0984cd0e6918970a9e4fc32595d3 assumeUTXO: fix peers disconnection during sync (furszy)\n598415bcc1d1f8d516159a1501dda24e8d7c2ea9 test: Work around boost compilation error (MarcoFalke)\n\nPull request description:\n\n  * #30834\n  * #30807\n  * #30880\n  * https://github.com/bitcoin-core/gui/pull/835\n  * #30899\n  * #30884\n\nACKs for top commit:\n  stickies-v:\n    ACK 06a7df70df30879e0b691d1a252636f703b8cdfb\n  hebasto:\n    ACK 06a7df70df30879e0b691d1a252636f703b8cdfb, I've backported the listed PRs locally. The only merge conflict I faced was in https://github.com/bitcoin/bitcoin/pull/30807. It was trivial to resolve.\n\nTree-SHA512: 779d734b50fdce379a20865ba30c969def028963ba51da0f497ddf1b5375e1f6166365295f226c1a07bab8be0c1aa0a6a3296fc6acd9fcf17bcc4874aac980a6","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2508903937\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30827\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30827/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30827\">bitcoin#30827</a>: [28.x] Further backports and rc2"}},{"before":"95ee66ae0b93a75d09ca270fc1e06d446a1e5eb0","after":"d48baa1319792ab522b0405871afa82be40d50f2","ref":"refs/heads/guix_glibc_static_pie","pushedAt":"2024-09-17T14:44:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"guix: build glibc with --enable-static-pie\n\n> These static PIE executables are like static executables but can be\n> loaded at any address and provide additional security hardening benefits\n> at the cost of some memory and performance.  When the library is built with\n> --enable-static-pic the resulting libc.a is usable with GCC 8 and above to\n> create static PIE executables using the GCC option '-static-pie'. This\n> feature is currently supported on i386, x86_64 and x32 with binutils\n> 2.29 or later, and on aarch64 with binutils 2.30 or later.\n\nNote that from glibc 2.35 onwards, this option is replaced with a\n`--disable-*` variant, as glibc starts defaulting to this behaviour.\n\nNote that is also does not give us `-static-pie` release binaries, that\nrequires further changes.","shortMessageHtmlLink":"guix: build glibc with --enable-static-pie"}},{"before":"bdbc90f29ac71253b8f31059fbf81da0bffe3bc8","after":"6fc4692797121b54de0c54e5b09ee47f322c038a","ref":"refs/heads/master","pushedAt":"2024-09-17T14:29:23.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29624: doc: update NeedsRedownload() and nStatus comment\n\naf9f9878934f88036423021c70ef523b6c9e1c90 doc: update NeedsRedownload() comment (Sjors Provoost)\n\nPull request description:\n\n  Noticed two outdated comments while reviewing #29370.\n\n  Since #21009 we no longer roll back the chain, when a user updates a pre-segwit node to a modern node. In this unlikely scenario we tell the user to `-reindex`.\n\n  This PR updates a comment in `PopulateAndValidateSnapshot` to reflect that change. Ditto for the description of `nStatus` in `chain.h`.\n\nACKs for top commit:\n  maflcko:\n    re-ACK af9f9878934f88036423021c70ef523b6c9e1c90\n  fjahr:\n    ACK af9f9878934f88036423021c70ef523b6c9e1c90\n\nTree-SHA512: d590f1cff6823297764c863753ed5478b8933d503c43933902d50b449dfd852a02aeb318c072ad25d02e4c2583d7026cd176a10b0584292d6bbe381a063f5c45","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2180051250\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29624\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29624/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29624\">bitcoin#29624</a>: doc: update NeedsRedownload() and nStatus comment"}},{"before":"a95e742b69207d7541afc6903b3fd72131f4d6de","after":"bdbc90f29ac71253b8f31059fbf81da0bffe3bc8","ref":"refs/heads/master","pushedAt":"2024-09-17T14:20:24.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30902: Remove Autotools packages from CI (and depends doc)\n\n7a8a6a06676dcb4066cc81a4e6872281a09bb00d doc: Fix comment in `contrib/devtools/check-deps.sh` script (Hennadii Stepanov)\n712d105e0935d31915c067bb90c54b71f6c5f4f5 depends, doc: Do not install Autotools packages (Hennadii Stepanov)\nb786449e663b6534abd0239e38122b9d082b90d8 ci: Do not install Autotools packages (Hennadii Stepanov)\n\nPull request description:\n\n  This PR is a follow-up to https://github.com/bitcoin/bitcoin/pull/30752 and addresses https://github.com/bitcoin/bitcoin/pull/30752#discussion_r1758594864.\n\nACKs for top commit:\n  kevkevinpal:\n    ACK [7a8a6a0](https://github.com/bitcoin/bitcoin/pull/30902/commits/7a8a6a06676dcb4066cc81a4e6872281a09bb00d)\n\nTree-SHA512: ac701b34ebf1621be355a5b576032d30a342a5667eff47d858587ac3c60011d77bd469e524d69dae90a932f14269227886e3d170a63a2e855b29ef4fa5b9e5a4","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2526338384\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30902\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30902/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30902\">bitcoin#30902</a>: Remove Autotools packages from CI (and depends doc)"}},{"before":"225718eda89d65a7041c33e1994d3bf7bd71bbdd","after":"a95e742b69207d7541afc6903b3fd72131f4d6de","ref":"refs/heads/master","pushedAt":"2024-09-17T14:12:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30913: ci: Use macos-14 GHA image (x86_64-apple-darwin22.6.0 -> arm64-apple-darwin23.6.0)\n\nfab932b4211ea0a4c10e484c08042552f9c58c15 ci: Remove incorrectly hardcoded HOST in mac_native task (MarcoFalke)\nfa8f35d786506eadfde3521e949bf5cdb4eb0003 ci: Use macos-14 GHA image (MarcoFalke)\n\nPull request description:\n\n  There shouldn't be any downside, because XCode remains pinned to the same version.\n\n  However, builds are expected to be a bit faster with M1, which seems nice.\n\nACKs for top commit:\n  hebasto:\n    ACK fab932b4211ea0a4c10e484c08042552f9c58c15.\n  willcl-ark:\n    ACK fab932b4211ea0a4c10e484c08042552f9c58c15\n\nTree-SHA512: 9719e05c67b8b5f3d59bd1a38eef00407b1ae5e123b18151c494b6d2dbf55bd2b0b5bb6c1a0469635c7b3bb5f23990d3bb2f339f56ce3955e8a1b97ac9f295d4","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2530314651\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30913\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30913/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30913\">bitcoin#30913</a>: ci: Use macos-14 GHA image (x86_64-apple-darwin2…"}},{"before":"462d62d4941465ceac8c286d2c9a8da9fcef0044","after":null,"ref":"refs/heads/guix_cmake_minimal_3_30","pushedAt":"2024-09-17T12:43:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"}},{"before":"acbe7ef656ad15f1ebf97624f56a48fb059ac960","after":"95ee66ae0b93a75d09ca270fc1e06d446a1e5eb0","ref":"refs/heads/guix_glibc_static_pie","pushedAt":"2024-09-17T09:35:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"guix: build glibc with --enable-static-pie\n\n> These static PIE executables are like static executables but can be\n> loaded at any address and provide additional security hardening benefits\n> at the cost of some memory and performance.  When the library is built with\n> --enable-static-pic the resulting libc.a is usable with GCC 8 and above to\n> create static PIE executables using the GCC option '-static-pie'. This\n> feature is currently supported on i386, x86_64 and x32 with binutils\n> 2.29 or later, and on aarch64 with binutils 2.30 or later.\n\nNote that from glibc 2.35 onwards, this option is replaced with a\n`--disable-*` variant, as glibc starts defaulting to this behaviour.\n\nNote that is also does not give us `-static-pie` release binaries, that\nrequires further changes.","shortMessageHtmlLink":"guix: build glibc with --enable-static-pie"}},{"before":"007c8ea6f394b343f1dcc6bddacdf47d62bb70f5","after":"acf8b52a59565617d89cd9b0006ba54c0a1f448d","ref":"refs/heads/depends_qt_5_15_15","pushedAt":"2024-09-17T09:33:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"depends: Qt 5.15.15","shortMessageHtmlLink":"depends: Qt 5.15.15"}},{"before":"260c41d1f390b272ac258bc17dd3be5c929b5685","after":"8ccae50bb79df0fb8f620edf39e22602e95c339e","ref":"refs/heads/guix_latest","pushedAt":"2024-09-17T09:12:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"[WIP] guix: update to 8dae6b47542b906682f83b06b0478fcbd0776fd6\n\nCurrently, this causes atleast the riscv64 build to fail. glibc fails to\nbuild with the new binutils (2.41).\n\nPackage updates:\nfile 5.44 -> 5.45\n(base) glibc 2.35 -> 2.39\ngrep 3.8 -> 3.11\ndiffutils 3.8 -> 3.10\ngawk 5.2.1 -> 5.3.0\ngzip 1.12 -> 1.13\nxz 5.2.8 -> 5.4.5\nmake 4.3 -> 4.4.1\nbinutils 2.38 -> 2.41\nlinux-headers 6.1.106 -> 6.1.109\n\nCMake-3.30 becomes available.","shortMessageHtmlLink":"[WIP] guix: update to 8dae6b47542b906682f83b06b0478fcbd0776fd6"}},{"before":"9f1aa88d4d9596aeb5220fa30ee3972294b62793","after":"225718eda89d65a7041c33e1994d3bf7bd71bbdd","ref":"refs/heads/master","pushedAt":"2024-09-17T08:48:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30438: guix: (explicitly) build Linux GCC with `--enable-cet`\n\n89bf11b807252fe5839b5b18742e24568dfe7bbd guix: build Linux GCC with --enable-cet (fanquake)\n\nPull request description:\n\n  Similar to #29695, and in the same vein of explicitly configuring hardening options in our release toolchain.\n\n  See https://gcc.gnu.org/install/configure.html:\n\n  >` --enable-cet`\n\n  > Enable building target run-time libraries with control-flow instrumentation, see `-fcf-protection option`. When --enable-cet is specified target libraries are configured to add `-fcf-protection` and, if needed, other target specific options to a set of building options.\n\n  > `--enable-cet=auto` is default. CET is enabled on Linux/x86 if target binutils supports Intel CET instructions and disabled otherwise. In this case, the target libraries are configured to get additional `-fcf-protection` option.\n\nACKs for top commit:\n  TheCharlatan:\n    ACK 89bf11b807252fe5839b5b18742e24568dfe7bbd\n\nTree-SHA512: 772d8529713a31e5db42be4e053582bb9ba6f26079ae136c6bf8303c4992a90d61159dbb0fde7a4b4cb7b4bf5024d5397a78004e6188b36e1c36dd5e5cdc49ad","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2405360200\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30438\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30438/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30438\">bitcoin#30438</a>: guix: (explicitly) build Linux GCC with `--enabl…"}},{"before":"89bf11b807252fe5839b5b18742e24568dfe7bbd","after":null,"ref":"refs/heads/enable_cet","pushedAt":"2024-09-17T08:47:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"}},{"before":"2bf721e76a575e865518e5fe51f00ce975b70b6a","after":"9f1aa88d4d9596aeb5220fa30ee3972294b62793","ref":"refs/heads/master","pushedAt":"2024-09-17T08:23:46.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30884: streams: cache file position within AutoFile\n\na240e150e837b5a95ed19765a2e8b7c5b6013f35 streams: remove AutoFile::Get() entirely (Pieter Wuille)\ne624a9bef16b6335fd119c10698352b59bf2930a streams: cache file position within AutoFile (Pieter Wuille)\n\nPull request description:\n\n  Fixes #30833.\n\n  Instead of relying on frequent `ftell` calls (which appear to cause a significant slowdown on some systems) in XOR-enabled `AutoFile`s, cache the file position within `AutoFile` itself.\n\nACKs for top commit:\n  achow101:\n    ACK a240e150e837b5a95ed19765a2e8b7c5b6013f35\n  davidgumberg:\n    untested reACK https://github.com/bitcoin/bitcoin/pull/30884/commits/a240e150e837b5a95ed19765a2e8b7c5b6013f35\n  theStack:\n    Code-review ACK a240e150e837b5a95ed19765a2e8b7c5b6013f35\n\nTree-SHA512: fd3681edc018afaf955dc7a41a0c953ca80d46c1129e3c5b306c87c95aae93b2fe7b900794eb8b6f10491f9211645e7939918a28838295e6873eb226fca7006f","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2522785199\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30884\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30884/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30884\">bitcoin#30884</a>: streams: cache file position within AutoFile"}},{"before":"37679b856ce183ec256c12a680b93ad53ed94da6","after":"2bf721e76a575e865518e5fe51f00ce975b70b6a","ref":"refs/heads/master","pushedAt":"2024-09-16T18:54:40.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30661: fuzz: Test headers pre-sync through p2p\n\na97f43d63a6e835bae20b0bc5d536df98f55d8a0 fuzz: Add harness for p2p headers sync (marcofleon)\na0eaa4749fe0f755e113eee70dee1989bdc07ad5 Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check (marcofleon)\na3f6f5acd89f2f5bb136ec247f259d212e8944d0 build: Automatically define FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION for fuzz builds (marcofleon)\n0c02d4b2bdbc7a3fc3031a63b3b16bafa669d51c net_processing: Make MAX_HEADERS_RESULTS a PeerManager option (marcofleon)\n\nPull request description:\n\n  This PR reopens https://github.com/bitcoin/bitcoin/pull/28043. It's a regression fuzz test for https://github.com/bitcoin/bitcoin/pull/26355 and [a couple bugs](https://github.com/bitcoin/bitcoin/pull/25717/commits/ed6cddd98e32263fc116a4380af6d66da20da990) that were addressed in https://github.com/bitcoin/bitcoin/pull/25717. This should help us move forward with the [removal of mainnet checkpoints](https://github.com/bitcoin/bitcoin/pull/25725).\n\n  It seems like the main concern in https://github.com/bitcoin/bitcoin/pull/28043 was the global mock function for proof of work. This PR aims to be an improvement by replacing the previous approach with a fuzz build configured using `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION`. This ensures that the simplified test code will never be in a release binary. If we agree this is the way to go, there are some other places (for future targets) where this method could be used.\n\n  In this target, PoW isn't being tested, so the goal is to bypass the check and let the fuzzer do its thing. In the other harnesses where PoW is actually being fuzzed, `CheckProofOfWork` is now `CheckProofOfWorkImpl`. So, the only change to that function is in the name.\n\n  More about `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` can be found at https://llvm.org/docs/LibFuzzer.html#fuzzer-friendly-build-mode and https://github.com/AFLplusplus/AFLplusplus/blob/stable/docs/fuzzing_in_depth.md#d-modifying-the-target.\n\nACKs for top commit:\n  naumenkogs:\n    ACK a97f43d63a6e835bae20b0bc5d536df98f55d8a0\n  dergoegge:\n    reACK a97f43d63a6e835bae20b0bc5d536df98f55d8a0\n  instagibbs:\n    tested ACK a97f43d63a6e835bae20b0bc5d536df98f55d8a0\n  brunoerg:\n    ACK a97f43d63a6e835bae20b0bc5d536df98f55d8a0\n\nTree-SHA512: 60b0bc6aadd8ca4c39db9cbba2da2debaaf68afcb6a8dd75c1ce48ca9e3996948fda8020930b6771a424e0f7c41b0b1068db4aa7dbe517f8fc152f1f712058ad","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2468329422\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30661\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30661/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30661\">bitcoin#30661</a>: fuzz: Test headers pre-sync through p2p"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQxNTowNTo1OS4wMDAwMDBazwAAAAS8GJqt","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQxNTowNTo1OS4wMDAwMDBazwAAAAS8GJqt","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQxODo1NDo0MC4wMDAwMDBazwAAAAS3x2pf"}},"title":"Activity · fanquake/bitcoin"}