Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoothsurf works incorrectly #53

Closed
StudentFS2 opened this issue Jan 22, 2021 · 1 comment
Closed

smoothsurf works incorrectly #53

StudentFS2 opened this issue Jan 22, 2021 · 1 comment

Comments

@StudentFS2
Copy link

Hi!
smoothsurf clearly work incorrectly on my geometry. I attach geometry here
files.zip
load('el.mat')
load('no.mat')
plotmesh(no,el)
sz=size(no);
no=smoothsurf(no,[],meshconn(el,sz(1)),1);
plotmesh(no,el)
clearly puts something inside of one of the channels.
Best regards

@fangq
Copy link
Owner

fangq commented Jun 6, 2021

@StudentFS2, again, sorry for not reading about this report until now.

I loaded your data, it looks like the garbled nodes/elements are there already before smoothsurf.

the presence of these garbled nodes is caused by a upstream CGAL bug I explained in #54 - the meshing process failed to complete before reaching the maximum node limit (type length(no), you can see it is 40,000, which is the default maximum node limit of vol2surf.)

because of this, I am closing this ticket because smoothsurf works as expected. it was vol2surf (specifically, cgalsurf) that failed to create a valid mesh.

@fangq fangq closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants