Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(hedgedoc): bump version to 1.9.9 (includes security fix) #27

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

jdreichmann
Copy link
Contributor

@jdreichmann jdreichmann requested a review from jcgruenhage as a code owner July 31, 2023 08:53
@CLAassistant
Copy link

CLAassistant commented Jul 31, 2023

CLA assistant check
All committers have signed the CLA.

@jcgruenhage
Copy link
Contributor

Can you change the committer email, so that the CLA bot is happy, and upload your PGP key to github, so that they are happy too?

@jdreichmann
Copy link
Contributor Author

Can you change the committer email, so that the CLA bot is happy, and upload your PGP key to github, so that they are happy too?

My OpenPGP key is uploaded to Github, despite Github falsely claiming "This user has not yet uploaded their public signing key. ". Also i am using my normal committer email i use everytime/everywhere.

@jdreichmann
Copy link
Contributor Author

Ansible lint seems to not run in progressive mode, blocking updates (incl security fixes) from being merged due to linting problems in unrelated roles.

@jcgruenhage
Copy link
Contributor

you're using Johanna Dorothea Reichmann <[email protected]> as author information here, which causes github to assign that commit to @transcaffeine, which does not have the PGP key uploaded yet. It seems to me like you're trying to split between work and private accounts here, if so, you need to split your author information as well.

With regards to blocking the merge: That's the signature that's not able to be verified, not the linting. The linting isn't marked as "required", so it won't block the merge.

@jdreichmann jdreichmann merged commit c198402 into main Jul 31, 2023
@jdreichmann jdreichmann deleted the transcaffeine/hedgedoc-1.9.9 branch July 31, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants