Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.2 tests fail with websockets and uvicorn: BaseEventLoop.create_connection() got an unexpected keyword argument 'extra_headers' #2415

Closed
Thermi opened this issue Dec 4, 2024 · 2 comments

Comments

@Thermi
Copy link

Thermi commented Dec 4, 2024

Errors are logged starting here (all with this unexpected keyword error):

https://gitlab.alpinelinux.org/Thermi/aports/-/jobs/1634733#L5023

@vytas7
Copy link
Member

vytas7 commented Dec 4, 2024

Hi @Thermi!
And thanks for reporting! This incompatibility has already been addressed in #2406, but the fix is not part of any stable release of Falcon yet.

This issue only started happening with a new version of websockets, 14.0, that went out after Falcon 4.0.2. Issues like this are basically impossible to avoid since we are trying not to pin anything unless necessary, and we can never know what future releases of 3rd party projects might bring. And even if we were pinning the test dependencies, that probably would be just counter-productive when it comes to Alpine Linux packages.

Until the next release of Falcon, there are two short-term alternatives for you to tackle this:

  1. Cherry pick cf51816 from our master branch as a patch in Alpine Linux.
  2. (Temporarily) drop the websockets test dependency. As of Falcon 4.0, the only hard test dependency is pytest, everything else is optional (see also here: Optional test dependencies).

I would also like to thank you for maintaining the py3-falcon package for Alpine users, much appreciated!

@vytas7 vytas7 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
@vytas7
Copy link
Member

vytas7 commented Dec 4, 2024

(Duplicates #2406.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants