Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design proposals for new topic pages: #194

Open
jankrcal opened this issue Aug 8, 2022 · 1 comment
Open

Design proposals for new topic pages: #194

jankrcal opened this issue Aug 8, 2022 · 1 comment
Assignees

Comments

@jankrcal
Copy link
Member

jankrcal commented Aug 8, 2022

Based on comments of Martin:

  • Numbers at the top of the topic page: I'm proud they link the source though the visual positioning of the "external" icon seems a bit odd, often in the middle of empty space. I understand you wanted to be minimalistic (without saying "Source" in each). I'm unsure what would be a better solution, though... My thoughts: Maybe the "i" (info) symbol instead of "external"? Maybe have the number be the link with no symbol? Maybe keep the external symbol but position it after the end of the text under the number?
  • On the topic page, the "In a nutshell" section (V kostce) is not in the navbar, yet uses the same style as the navbar. Not tragic, just confused me a bit. Maybe having the link to "V kostce" instead of the current link of "Uvod" and adding a link to the topic name (above subtopics in navbar) pointing that to the top of the page?
  • [more web-cz related] Co sa tyka ilustracii tem na titulnej stranke: Od pohladu mi nie je zjavne, ze su to tlacitka. Na desktope to este relativne ide (pretoze menia farbu na hover), ale na mobile to dost vyzera ako "ilustrovany zoznam tem". Vaham, ako to co najjednoduhsie podporit: Mne by mozno pomohlo za nazov oblasti vlozit sipku alebo ">", aby to symbolizovalo, ze je tam nieco viac?
@jankrcal
Copy link
Member Author

jankrcal commented Aug 8, 2022

@kikinna This is non-blocking review feedback from @mukrop. Do you like any of the proposals from above?

I'd skip the first one as we've spent quite some time exploring. The other two sound compelling to me but I'd love to hear your thoughts first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants