Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust OG preview images #151

Open
mukrop opened this issue Jan 28, 2022 · 0 comments
Open

Adjust OG preview images #151

mukrop opened this issue Jan 28, 2022 · 0 comments
Labels
2: medium priority Not essential, but we want to work on it free-to-take Described piece of work you can do

Comments

@mukrop
Copy link
Member

mukrop commented Jan 28, 2022

Problems (discussed with Milan and Kristi):

  • OG previews get cut since both Twitter and Facebook dimensions are different from the current aspect ratio,
  • Milan has to create appropriately sized versions for social networks manually.

Proposed:

  • Generate appropriate OG sized images at build time (as whitespace as necessary).
  • Adjust OG header to link proper Twitter and Facebook previews.

Further comments:

  • In the future, we'll have "display versions" of infographics (16:9) which will be more appropriate at least for Twitter. Thus, keep in mind there will be condition generation in the future (if display version exists, it will get used instead of the normal with margins).
  • Milan needs access to transformed images. For now, we'll teach him to download the appropriate image from the web. For the future, think about either generating such images into a gDrive folder or a post-commit hook on graphics repo.
  • Open Graph details available here: https://ogp.me/
@mukrop mukrop added free-to-take Described piece of work you can do 2: medium priority Not essential, but we want to work on it labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: medium priority Not essential, but we want to work on it free-to-take Described piece of work you can do
Projects
None yet
Development

No branches or pull requests

1 participant