Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random anime characters or movie and TV drama characters #3121

Open
h-yw opened this issue Sep 18, 2024 · 3 comments
Open

Add random anime characters or movie and TV drama characters #3121

h-yw opened this issue Sep 18, 2024 · 3 comments
Labels
c: feature Request for new feature s: waiting for user interest Waiting for more users interested in this feature
Milestone

Comments

@h-yw
Copy link

h-yw commented Sep 18, 2024

Clear and concise description of the problem

I want to include the names of characters from anime or movies in the dataset. When getting a random name, you can use the name from the specified anime or movie show

Suggested solution

  • example of English:

    • Game of Thrones: ["Tyrion Lannister","Cersei Lannister","Daenerys Targaryen","Jon Snow"]
    • ...
  • example of Chinese:

    • 权力的游戏: ["提利昂·兰尼斯特","瑟曦·兰尼斯特","丹妮莉丝·坦格利安","琼恩·雪诺"]
    • ...

Alternative

No response

Additional context

No response

@h-yw h-yw added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Sep 18, 2024
Copy link
Contributor

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@ST-DDT ST-DDT added this to the vFuture milestone Sep 18, 2024
@xDivisionByZerox xDivisionByZerox removed the s: pending triage Pending Triage label Sep 22, 2024
@UmairJibran
Copy link
Contributor

I would like to take it on, as soon as it's considered to be developed.

cc: @ST-DDT @matthewmayer @xDivisionByZerox

@matthewmayer
Copy link
Contributor

My main concern would be how do you prevent this from getting out of control in size as likely many contributors would want to add their favorite movie/anime/tv show?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature s: waiting for user interest Waiting for more users interested in this feature
Projects
None yet
Development

No branches or pull requests

5 participants