Fix unit tests

[facundoolano]

In case someone has the time (I don't), it would be very helpful to get the unit tests back passing. This would simplify the PR review and merge process since it would make it obvious when code changes break things.

[tpwatson]

I'm working on this, but the comments are failing. I don't know if comments are even available anymore, I don't remember where they are, or what they are for or are about. I'm not sure if we can still even get comments. Wondering if they can be disregarded now.

[facundoolano]

Hey @tpwatson I'm not positive but I think the comments field used to include the inline review texts that were loaded on the main app page (as opposed to the full review list exposed by the reviews method that comes from a separate google play endpoint).

So as an example, for this app it would be these reviews at the bottom:

[facundoolano]

Example from an earlier version of the README:

google-play-scraper/README.md

Line 75 in 84f5e93

comments: ['Great! Its a great time waster'],

[tpwatson]

Thanks for the clarification. I have all tests passing, all though randomly the throttle test fails due to a timeout error. I'm not sure if it's because we still need to get got updated. But the requests probably are not returning fast enough sometimes.

[facundoolano]

are you already overriding the timeout threshold (as done here)?

[tpwatson]

No I just left it as is.

I thought I had them all passing but running into trouble with suggested search tests failing. Trying to figure out how to get the mappings working.

75 passing (1m)
2 failing

1. Search method
   suggested search
   should return apps from suggested search:
   TypeError: Cannot read properties of undefined (reading 'map')
   at C:\Users\watso\Documents\GitHub\google-play-scraper\node_modules\ramda\dist\ramda.js:578:31
   at Object.f2 [as map] (node_modules\ramda\dist\ramda.js:473:22)
   at processFirstPage (lib\search.js:101:27)
   at C:\Users\watso\Documents\GitHub\google-play-scraper\lib\search.js:31:21
   at runMicrotasks ()
   at processTicksAndRejections (node:internal/process/task_queues:96:5)

2. Search method
   suggested search
   should return apps from suggested search in european country:
   TypeError: Cannot read properties of undefined (reading 'map')
   at C:\Users\watso\Documents\GitHub\google-play-scraper\node_modules\ramda\dist\ramda.js:578:31
   at Object.f2 [as map] (node_modules\ramda\dist\ramda.js:473:22)
   at processFirstPage (lib\search.js:101:27)
   at C:\Users\watso\Documents\GitHub\google-play-scraper\lib\search.js:31:21
   at runMicrotasks ()
   at processTicksAndRejections (node:internal/process/task_queues:96:5)

ds:4 is correct in:
const INITIAL_MAPPINGS = {
app: ['ds:4', 0, 1, 0, 23],
sections: ['ds:4', 0, 1]
};
But I'm wondering if the other numbers are off, not sure how count the highly nested AF_initDataCallback data

[tpwatson]

So I've figured out how to count the mappings in an easier way, if I can actually fix the mapping issue I'll document it in the code for future use. But here is how to work with mappings and count them:

Get a full copy of the AF_initDataCallback object, its not JSON but you can use a Javascript object to JSON converter:
https://www.convertsimple.com/convert-javascript-to-json/

Paste the JS object in that site and you'll get the JSON version.

Then copy the JSON version and take it to:
https://jsonpathfinder.com/

Then you can find out the position of each piece of data much easier.

But what I've gotten stumped on now, is that when you misspell a search term, like 'runing app' instead of 'running app' the mappings will be different from the correctly spelled results.

So I have the mappings to correctly get the data for suggested search, but I'm trying to figure out how to put that into the search.js file so that when the results page has "Searching instead for [correct spelling search term]" it will use the other set of mappings.

It's a lot to digest how the current codebase works, I'm struggling to figure it out 100%, especially because ramda is essentially a blackbox for me, but I'm trying.

[tpwatson]

Just got all 77 tests passing! 🎉

Going to try my best to refactor the code and submit the PR asap!

Hopefully its acceptable!

[facundoolano]

Closed by #649