Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutation with no arguments failing in actionGroup #54

Open
ottopaulsen opened this issue Jan 8, 2021 · 1 comment
Open

Mutation with no arguments failing in actionGroup #54

ottopaulsen opened this issue Jan 8, 2021 · 1 comment

Comments

@ottopaulsen
Copy link

I am nut sure if this is a bug, or if there is a way around, but it is a challenge anyway.

I have a mutation that takes no payload. (It just clears a list.)
It looks like this doesn't work properly in an actionGroup.
I think the problem is that there is no payload to add the actionGroup in, and at the moment I am not able to add an empty object as payload.

As a workaround I add a dummy payload, but it would be nice to have a better way.

Also, in the documentation it is referred to test/test-action-group-undo.js. This file does not exist.

@andrewbeng89
Copy link
Member

Hi @ottopaulsen, thanks for your feedback and query about this issue.

Based on your user experience, I would have to agree that this isn't the optimal behaviour for the actionGroup feature and that payload should have some default value if a mutation does not require any.

I will also look into correcting the unit test reference: it should be tests/unit/test.action-group.spec.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants