Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggeste to improve the math rigorousness for "Flow Matching Guide and Code" #33

Open
wangmiaowei opened this issue Feb 10, 2025 · 4 comments

Comments

@wangmiaowei
Copy link

Thanks for your contribution in this tutorial(https://arxiv.org/pdf/2412.06264), but I noticed several math errors when reading the first several parts:

  1. please use the partial derivative not total derivative for the conservation.

Image

  1. Error in this equation, should not include tri in Expectation.

Image

.... I will keep on reviewing this book.

@wangmiaowei
Copy link
Author

update: error:

Image.

really suggest to remodify this guidance.

@kashif
Copy link
Contributor

kashif commented Feb 13, 2025

2nd typo already flagged in #26

@wangmiaowei
Copy link
Author

wangmiaowei commented Feb 13, 2025

Image why a superscript for x? in fact, symbols in a messy (for example, q(y) not q(x) during forward Euler.), not good for beginner

@wangmiaowei
Copy link
Author

Imageconfusion about "near noise"... to me the singularity is caused by the sigma... so i think should be 'near data'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants