From 37f102f25d803518d7eca891e241104a0fe7a4a4 Mon Sep 17 00:00:00 2001
From: Brian Muse <brianmuse@meta.com>
Date: Mon, 27 Mar 2023 13:32:29 -0700
Subject: [PATCH] Support custom test configurations in the PL Test Runner
 (#2246)

Summary:
Pull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2246

## Context
Right now we have 3 different test runner workflow to essentially just change which config they use.

## This Diff
This diff updates the main PL E2E workflow to support a config parameter so we can run all PL tests on it and deprecate the other two workflows.

Reviewed By: ajinkya-ghonge

Differential Revision: D44433105

fbshipit-source-id: 2a95a073170e075b0457560d9622631530006a79
---
 .github/workflows/one_command_runner_test.yml | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/one_command_runner_test.yml b/.github/workflows/one_command_runner_test.yml
index 5f7409f96..8cc87f5af 100644
--- a/.github/workflows/one_command_runner_test.yml
+++ b/.github/workflows/one_command_runner_test.yml
@@ -1,4 +1,4 @@
-name: One command runner test
+name: Private Lift Test
 run-name: ${{ inputs.test_name }} on ${{ inputs.tag }} for build ${{ inputs.build_id }}
 
 on:
@@ -41,6 +41,11 @@ on:
         description: The name of the type of tests that are being run
         default: 'PL E2E Tests'
         type: string
+      test_config:
+        description: The yaml file name that will be passed in the --config parameter to the E2E runner
+        default: 'config_one_command_runner_test.yml'
+        type: string
+        required: true
       tracker_hash:
         description: '[Internal usage] Used for tracking workflow job status within Meta infra'
         required: false
@@ -84,6 +89,12 @@ on:
         options:
           - PL E2E Tests
           - Multi-key PL E2E Tests
+          - UDP Tests
+      test_config:
+        description: The yaml file name that will be passed in the --config parameter to the E2E runner
+        default: 'config_one_command_runner_test.yml'
+        type: string
+        required: false
       tracker_hash:
         description: '[Internal usage] Used for tracking workflow job status within Meta infra'
         required: false
@@ -94,6 +105,7 @@ env:
   FBPCS_IMAGE_NAME: pc-coordinator-prod
   FBPCS_GRAPH_API_TOKEN: ${{ secrets.FBPCS_GRAPH_API_TOKEN }}
   CONSOLE_OUTPUT_FILE: /tmp/output.txt
+  CONFIG_YAML: ./fbpcs/tests/github/${{ inputs.test_config }}
 
 jobs:
   ### Private Lift E2E tests
@@ -132,7 +144,7 @@ jobs:
           ${{ inputs.study_id }} \
           --objective_ids=${{ inputs.objective_id }} \
           --input_paths=${{ inputs.input_path }} \
-          --config=./fbpcs/tests/github/config_one_command_runner_test.yml \
+          --config="$CONFIG_YAML" \
           -- \
           --version=${{ inputs.tag }} \
           --image_version=${{ inputs.coordinator_tag }} \