Skip to content

Commit

Permalink
Support custom test configurations in the PL Test Runner (#2246)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2246

## Context
Right now we have 3 different test runner workflow to essentially just change which config they use.

## This Diff
This diff updates the main PL E2E workflow to support a config parameter so we can run all PL tests on it and deprecate the other two workflows.

Reviewed By: ajinkya-ghonge

Differential Revision: D44433105

fbshipit-source-id: 2a95a073170e075b0457560d9622631530006a79
  • Loading branch information
musebc authored and facebook-github-bot committed Mar 27, 2023
1 parent c08a437 commit 37f102f
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions .github/workflows/one_command_runner_test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: One command runner test
name: Private Lift Test
run-name: ${{ inputs.test_name }} on ${{ inputs.tag }} for build ${{ inputs.build_id }}

on:
Expand Down Expand Up @@ -41,6 +41,11 @@ on:
description: The name of the type of tests that are being run
default: 'PL E2E Tests'
type: string
test_config:
description: The yaml file name that will be passed in the --config parameter to the E2E runner
default: 'config_one_command_runner_test.yml'
type: string
required: true
tracker_hash:
description: '[Internal usage] Used for tracking workflow job status within Meta infra'
required: false
Expand Down Expand Up @@ -84,6 +89,12 @@ on:
options:
- PL E2E Tests
- Multi-key PL E2E Tests
- UDP Tests
test_config:
description: The yaml file name that will be passed in the --config parameter to the E2E runner
default: 'config_one_command_runner_test.yml'
type: string
required: false
tracker_hash:
description: '[Internal usage] Used for tracking workflow job status within Meta infra'
required: false
Expand All @@ -94,6 +105,7 @@ env:
FBPCS_IMAGE_NAME: pc-coordinator-prod
FBPCS_GRAPH_API_TOKEN: ${{ secrets.FBPCS_GRAPH_API_TOKEN }}
CONSOLE_OUTPUT_FILE: /tmp/output.txt
CONFIG_YAML: ./fbpcs/tests/github/${{ inputs.test_config }}

jobs:
### Private Lift E2E tests
Expand Down Expand Up @@ -132,7 +144,7 @@ jobs:
${{ inputs.study_id }} \
--objective_ids=${{ inputs.objective_id }} \
--input_paths=${{ inputs.input_path }} \
--config=./fbpcs/tests/github/config_one_command_runner_test.yml \
--config="$CONFIG_YAML" \
-- \
--version=${{ inputs.tag }} \
--image_version=${{ inputs.coordinator_tag }} \
Expand Down

0 comments on commit 37f102f

Please sign in to comment.