-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faiss-cpu 1.10.0 update broke RAGatouille install #4161
Comments
Hi @Quinn-Meyer-Sustainment, you're very fast! We haven't completely released 1.10.0 yet. The tagging was done yesterday but the package is not yet released to Pytorch channel due to some Github Actions workflow file issue. After release to the Pytorch channel, we will make the announcement. However I see you're also installing via pip which we don't officially support atm. Can you try with Conda? We did not see |
Ah, that would make sense. Conda only has 1.9.0 available at the moment whereas pypi is using 1.10.0, so unfortunately I cannot try its compatibility using 1.10.0 with Conda right now. I'm probably a super niche user. I'll monitor this issue again once it's fully released and provide a comment if Conda install works or not. I'm not sure if it makes sense to have an open issue with an unfinished release, so feel free to close this issue if you want! |
@Quinn-Meyer-Sustainment v1.10.0 is released to Conda now. Let us know if you still see the issue when installing with conda. |
I'm on AWS SageMaker Linux which uses Python 3.10 (Python 3.10.16), but the conda installer is saying Python 3.11 (Python 3.11.11 works) is required for faiss-cpu==1.10.0. Python 3.10.16 works with faiss-cpu==1.9.0. Is this new dependency intended, and if so is it documented somewhere? Error for "conda install pytorch::faiss-cpu==1.10.0"
|
We had to switch from the We do build python 3.9, 3.10, 3.11, and 3.12 packages in Conda, so it should be supported. Question: Do you have From the nightly logs when testing You can also try a conda install which also installs mkl=2023.0.0. pin-1 is not in our logs anywhere either.
|
Good call. AWS has the following MKL libraries preconfigured in their environment:
uninstalling prevoius mkl versions
fixed the issue. On a side note, when installing via the AWS pytorch kernel it automatically updates pytorch which causes installation failures. I'm not a packaging expert, but it does not happen in the same kernel with faiss-cpu==1.9.0.
|
Glad to see that uninstalling prior mkl versions worked! I'm not as familiar with the dependencies for pytorch unfortunately but it looks like it is trying to update Pytorch 2.2.2 to 2.4.1. What happens if you install the lower Pytorch version? Our test logs were using |
FYI new version of faiss-cpu 1.10.0 broke a previously working install with ragatouille.
Here is the error running "pip install ragatouille"
Confirmed that downgrading faiss-cpu==1.9.0 resulted in successful install
pip install faiss-cpu==1.9.0 # downgrade required for ragatouille, fais-cpu==1.10.0 broke it
pip install ragatouille
Edit:
SWIG Version 3.0.12
OS: Amazon Linux 2 ("centos rhel fedora")
The text was updated successfully, but these errors were encountered: