Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Do not use dev Kotlin version #53

Open
irenedea opened this issue May 4, 2022 · 0 comments · May be fixed by #104
Open

Do not use dev Kotlin version #53

irenedea opened this issue May 4, 2022 · 0 comments · May be fixed by #104

Comments

@irenedea
Copy link

irenedea commented May 4, 2022

We were using the Kotlin dev version because shapeTyping is dependent on some compiler changes that are not released in the main build yet.

This issue should be addressed when our changes are in the main build for Kotlin. I believe this should be in the 1.7.0 release (currently latest the Kotlin version is 1.6.21)

There are two things to do:

  1. Update the Kotlin version to a non dev version from MavenCentral
  2. Remove dependency to the kotlin bootstrap maven repository

maven repository dependency:
https://github.com/facebookresearch/diffkt/blob/main/kotlin/build.gradle.kts#L41
https://github.com/facebookresearch/diffkt/blob/main/kotlin/settings.gradle.kts#L32

Kotlin version is declared here: https://github.com/facebookresearch/diffkt/blob/main/kotlin/gradle.properties#L9

@gafter gafter transferred this issue from another repository May 24, 2022
@irenedea irenedea linked a pull request Jul 8, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant