Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor model class hierarchy #381

Open
crasanders opened this issue Sep 8, 2024 · 0 comments
Open

Refactor model class hierarchy #381

crasanders opened this issue Sep 8, 2024 · 0 comments

Comments

@crasanders
Copy link
Contributor

The current model class hierarchy is a bit confusing:

  • We have the AEPsychMixin, which should be made into a proper base class because it's being used as one instead of as a Mixin. This would make the code more straightforward and allow us to get rid of the clunky ModelProtocol.
  • A lot of model classes inherit from GPClassificationModel, even if they don't actually do classification (e.g., the Beta and Ordinal outcome models). Instead we should have a VariationalModel superclass that all these different models inherit from.

See the class structure in the ax-backend branch for an example of what the class hierarchy could look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant