From 3401268aa1bc3219998986d0b4693d8c0f02f680 Mon Sep 17 00:00:00 2001 From: Mia Garrard Date: Fri, 19 Jan 2024 09:52:55 -0800 Subject: [PATCH] Update all instances of MinimumPreferenceOccurances to directly use TransitionCriterion (#327) Summary: X-link: https://github.com/facebook/Ax/pull/2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Differential Revision: D52852317 --- .../completion_criterion/min_total_outcome_occurrences.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aepsych/generators/completion_criterion/min_total_outcome_occurrences.py b/aepsych/generators/completion_criterion/min_total_outcome_occurrences.py index 3a27d68df..ea2ee0519 100644 --- a/aepsych/generators/completion_criterion/min_total_outcome_occurrences.py +++ b/aepsych/generators/completion_criterion/min_total_outcome_occurrences.py @@ -9,7 +9,7 @@ from aepsych.config import Config, ConfigurableMixin -from ax.modelbridge.completion_criterion import MinimumPreferenceOccurances +from ax.modelbridge.transition_criterion import MinimumPreferenceOccurances class MinTotalOutcomeOccurrences(MinimumPreferenceOccurances, ConfigurableMixin):