Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hdfs): Fix the failed unit tests in velox_hdfs_file_test #11884

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JkSelf
Copy link
Collaborator

@JkSelf JkSelf commented Dec 17, 2024

Fix #11857.

@JkSelf JkSelf requested a review from majetideepak as a code owner December 17, 2024 01:10
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit c352bb2
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/676cf20bfde2de00083f7f1c

@JkSelf JkSelf changed the title Fix the failed unit tests in velox_hdfs_file_test fix(hdfs): Fix the failed unit tests in velox_hdfs_file_test Dec 17, 2024
@JkSelf JkSelf force-pushed the hdfs-ci-failure branch 2 times, most recently from 20fb698 to 5f2b957 Compare December 17, 2024 07:42
@JkSelf
Copy link
Collaborator Author

JkSelf commented Dec 17, 2024

@majetideepak It seems that this issue is intermittent. I can't reproduce it locally, and it doesn't occur consistently on Velox CI either.

@majetideepak
Copy link
Collaborator

@JkSelf It does look nondeterministic. The test seems to be passing now.

@JkSelf
Copy link
Collaborator Author

JkSelf commented Dec 18, 2024

@JkSelf It does look nondeterministic. The test seems to be passing now.

@majetideepak Yes. I will close this pr.

@JkSelf JkSelf closed this Dec 18, 2024
@JkSelf JkSelf reopened this Dec 20, 2024
@JkSelf JkSelf force-pushed the hdfs-ci-failure branch 2 times, most recently from 52cf355 to c352bb2 Compare December 26, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velox_hdfs_file_test HdfsFileSystemTest SetUpTestSuite Exceptions in CI
3 participants