Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geometry support to Velox #11814

Open
wraymo opened this issue Dec 10, 2024 · 1 comment
Open

Add Geometry support to Velox #11814

wraymo opened this issue Dec 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@wraymo
Copy link

wraymo commented Dec 10, 2024

Description

The Geometry type is already available in PrestoDB. Incorporating a similar type in Velox would align it with modern requirements for geospatial analytics.

To achieve this, I plan to add GeometryType as a custom type in Prestissimo and incrementally introduce new UDFs. The tasks can be divided into multiple PRs:

  • Add the Geometry type and tests.
  • Introduce the necessary library dependency (e.g., GEOS) for geometry manipulation.
  • Implement serialization and deserialization logic for the Geometry type and add tests.
  • Add relevant UDFs (e.g. st_contains) for the geometry type and register them.

Looking forward to feedback and suggestions!

@wraymo wraymo added the enhancement New feature or request label Dec 10, 2024
@assignUser
Copy link
Collaborator

Introduce the necessary library dependency (e.g., GEOS) for geometry manipulation.

Ideally these should be optional imo. Could we add this as an modular, optional component (see storage_adapters wrt not leaking dependencies etc.).
Not sure if this is possible in Velox from a technical perspective (e.g. similar to extension types in arrow) or if it is more akin to change to the arrow spec (e.g. ListView etc.)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants