Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velox_sort_benchmark test failed to execute RealWorldData_stdSort #11794

Open
hackerwjx111-arch opened this issue Dec 9, 2024 · 1 comment
Open
Labels
bug Something isn't working triage Newly created issue that needs attention.

Comments

@hackerwjx111-arch
Copy link

Bug description

I build velox and velox benchmark and try to run velox_sort_benchmark. However, I didn't get RealWorldData_stdSort test result.
I copied parquet file cp ./velox/dwio/parquet/tests/examples/str_sort.parquet ../examples/
./_build/release/velox/exec/benchmarks/velox_sort_benchmark

[...]chmarks/RowContainerSortBenchmark.cpp relative time/iter iters/s

BM_Int64_stdSort(100k_uni_noseq) 20.01ms 49.98
BM_Int64_timSort(100k_uni_noseq) 94.081% 21.27ms 47.02

BM_Int64_stdSort(10k_uni_noseq) 1.51ms 663.87
BM_Int64_timSort(10k_uni_noseq) 93.650% 1.61ms 621.71

BM_Int64_stdSort(1k_uni_noseq) 110.81us 9.02K
BM_Int64_timSort(1k_uni_noseq) 95.584% 115.93us 8.63K

*** Aborted at 1733728790 (Unix time, try 'date -d @1733728790') ***
*** Signal 11 (SIGSEGV) (0x38) received by PID 296789 (pthread TID 0xef6666e77180) (linux TID 296789) (code: address not mapped to object), stack trace: ***
Segmentation fault (core dumped)

System information

It could be reproduced on x86 or arm platform.

Relevant logs

It seems that if fail when running this line:
std::vector<std::optional<StringView>> stdVector(querySigCol->size());
in RowContainerSortBenchmark.cpp
@hackerwjx111-arch hackerwjx111-arch added bug Something isn't working triage Newly created issue that needs attention. labels Dec 9, 2024
@hackerwjx111-arch
Copy link
Author

It seems that when cast data->as()->childAt(0) to data->as()->childAt(0)->asFlatVector(), which is from VARCHAR to FlatVector, the value will be changed from size 1000 to null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Newly created issue that needs attention.
Projects
None yet
Development

No branches or pull requests

1 participant