Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of GFlags from libvelox and use a global singleton config object instead #11730

Open
majetideepak opened this issue Dec 3, 2024 · 2 comments
Open

Remove usage of GFlags from libvelox and use a global singleton config object instead #11730

majetideepak opened this issue Dec 3, 2024 · 2 comments
Assignees
@majetideepak
Labels
enhancement New feature or request

Comments

@majetideepak
Copy link
Collaborator

Description

This allows libVelox to not depend on GFlags and simplifies the dynamic library build.
Current issue gflags(static -> linked into folly(static) -> linked intod velox(shared) -> linked to tests(shared) -> test also links to gflags (static) is reported here
#10732 (comment)
Velox applications and other components such as tools, tests, examples can continue to use GFlags.
@majetideepak majetideepak added the enhancement New feature or request label Dec 3, 2024
@majetideepak majetideepak self-assigned this Dec 3, 2024
@majetideepak
Copy link
Collaborator Author

CC: @assignUser, @kgpai

@majetideepak majetideepak changed the title Remove usage of GFlags from libvelox and use a Singleton Config object instead Remove usage of GFlags from libvelox and use a global singleton config object instead Dec 3, 2024
@majetideepak
Copy link
Collaborator Author

We could follow the MemoryManager::getInstance model.
https://github.com/facebookincubator/velox/blob/main/velox/common/memory/Memory.cpp#L185

@majetideepak majetideepak mentioned this issue Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majetideepak majetideepak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@majetideepak