Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Snapshot has already been released. #1994

Closed
jalyn-lee opened this issue Sep 2, 2022 · 12 comments · May be fixed by #2295
Closed

[BUG] Snapshot has already been released. #1994

jalyn-lee opened this issue Sep 2, 2022 · 12 comments · May be fixed by #2295
Labels
pending Pending more information or user action

Comments

@jalyn-lee
Copy link

From #1891,
this issue is not fixed at all in dev mode (firefox, safari browser).
when debug console is opened or after page refresh, it keeps throwing the error.
Could you possibly add examples of how to use urlSyncEffect properly?
There's so little examples on the official web site and I have no idea what has been done wrong.

@drarmstr drarmstr added the pending Pending more information or user action label Sep 16, 2022
@drarmstr
Copy link
Contributor

Can you provide a reproducer for the error? Is this related to #1936?

urlSyncEffect() is used the same as syncEffect() with just the addition of the history option. See these examples

@PiR1
Copy link

PiR1 commented Sep 19, 2022

I have the same issue.
I tried to reproduce it in this codesandbox: https://codesandbox.io/s/stupefied-tree-c2xd7t?file=/src/component.js. The error is thrown when you change the array size (for example from 500 to 5000:
snapshot has already been released
)
I tested this code on Chrome and it doesn't throw any error but it does in Firefox (104.0.2 & 105.0b9). I only tested those 2 browsers.
Also, I don't know if it's the same cause as in my full code.

@willoughby
Copy link

@PiR1 try using the 7.6 release as this resolved the issue for us, we was on 7.4.

@PiR1
Copy link

PiR1 commented Oct 19, 2022

@PiR1 try using the 7.6 release as this resolved the issue for us, we was on 7.4.

Yes, I'm on the latest version in my code and in the codesandbox but it doesn't resolve the issue.
As I said in the issue #1936 (which has been "resolved" in the version 7.5), the timeout delay added depends of the computer and app performances. So it doesn't fix the issue in all cases.

@davidnaas
Copy link

I have this issue as well using recoil 0.7.6 and recoil-sync 0.2.0.

I'm tied to a very specific version of webkit/safari webview and this issue makes it virtually impossible to use recoil-sync at all since the dev tools can not be opened without crashing the app

@Atrus619
Copy link

Atrus619 commented Mar 7, 2023

I'm having this issue on recoil 0.7.7, but only when using react 18.2.0, if I use react 17.0.2 the issue does not occur.

For reference, I am encountering this using a custom component in storybook, and it only occurs under specific circumstances

@d6u
Copy link

d6u commented Aug 20, 2023

I see #2243 is already merged. When are we going to release a new version with this fixed? Thanks!

@carolineartz
Copy link

carolineartz commented Oct 26, 2023

Hi, what is the status here? I see there is a PR #2243 (not merged) but no movement in a while...

@jalyn-lee
Copy link
Author

jalyn-lee commented Oct 27, 2023

I will close off this issue for now. It's been a while and I've mostly relied on chrome to avoid the hassle.
For those who are experiencing the same issue, I'd suggest using the chrome browser especially for handling large set of data which seems to be the case.

@Jeffy-Praneat
Copy link

how resolve the problem ?

@chriszrc
Copy link

@Jeffy-Praneat I added pnpm patch to the autoRelease_INTERNAL() function, making the timeout 100ms rather than 10, and now it works, see this issue - #1936

@ArthurGuez
Copy link

@chriszrc Thanks, it did the trick for my app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Pending more information or user action
Projects
None yet