Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

A translation file BUG #661

Open
NS-Sp4ce opened this issue Nov 14, 2018 · 0 comments
Open

A translation file BUG #661

NS-Sp4ce opened this issue Nov 14, 2018 · 0 comments

Comments

@NS-Sp4ce
Copy link

NS-Sp4ce commented Nov 14, 2018

https://github.com/facebook/fbctf/blob/4ec9b6be404fce1bed6d1066fccf10c4255767bb/src/controllers/AdminController.php#L3792

This kind of writing will cause the translation file to be invalid.

status_<span class="highlighted">{tr('OK')}</span>

Should be changed as follows.

{tr('status_')}<span class="highlighted">{tr('OK')}</span>

https://github.com/facebook/fbctf/blob/4ec9b6be404fce1bed6d1066fccf10c4255767bb/src/controllers/IndexController.php#L384
and
https://github.com/facebook/fbctf/blob/4ec9b6be404fce1bed6d1066fccf10c4255767bb/src/controllers/IndexController.php#L598

<h1 class="fb-glitch" data-text="Team Registration">

Should be changed as follows.

<h1 class="fb-glitch" data-text={tr('Team Registration')}>
@NS-Sp4ce NS-Sp4ce changed the title A Translation BUG A translation file BUG Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant