This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
Metrics dash board #168
Open
Metrics dash board #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to HH:MM:SS conversion
facebook-github-bot
added
the
CLA Signed
gaoxm
suggested changes
Mar 26, 2021
Comment on lines
+2204
to
+2212
| task_query = (TaskHistory.query.with_entities(TaskHistory.task_id) | ||
| .filter(TaskHistory.user_id==user.id) | ||
| .group_by(TaskHistory.task_id) | ||
| ).all() | ||
|
|
||
| pro_query=(TaskHistory.query.with_entities(TaskHistory.project_id) | ||
| .filter(TaskHistory.user_id==user.id) | ||
| .group_by(TaskHistory.project_id) | ||
| ).all() |
There was a problem hiding this comment.
since the same task ID may appear in multiple projects, this way of querying task IDs and project IDs separately and then iterate through all combinations seems very inefficient. Ideally this part should do one query like
SELECT DISTINCT project_id, task_id FROM task_history WHERE user_id = {user.id},
and then the query below should use the (project_id, task_id) tuples returned from this query to find relevant tasks and compute the "time spent on actions".
I'll let @zlavergne comment on how to do that in TM codebase.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zlavergne :Please review