Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Need to update Tasking Manager to bundle Rapid v2 #345

Open
Bonkles opened this issue Mar 22, 2023 · 3 comments
Open

Need to update Tasking Manager to bundle Rapid v2 #345

Bonkles opened this issue Mar 22, 2023 · 3 comments
Assignees

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Mar 22, 2023

Problem: TM4 is currently built with the rapid version tagged at facebookincubator/rapid#rapid-v1.1.9-tm.1.

This version still used rollup instead of esbuild due to as-yet-unknown issues with the emitted esbuild code that made it incompatible with the TM4 code. As such, we just cut special versions of rapid that were still built with rollup instead to work around this issue.

Describe the solution you'd like
We'd like an esbuilt-v2 version tag to be able to import the latest v2 code into TM4.

@Bonkles Bonkles self-assigned this Mar 22, 2023
@tsmock
Copy link
Contributor

tsmock commented Mar 22, 2023

Heads up: I'm working on updating a bunch of dependencies in the upstream TM. Let me know if there is a better version to use (https://github.com/facebook/Rapid/releases/tag/rapid-v2.0.0b-tm.1 ?).

@Bonkles
Copy link
Contributor Author

Bonkles commented Mar 22, 2023

That is precisely the one! Thanks. FYI even though that tag is marked Beta, it is our current release candidate for RapiD, barring any other must-fixes we need to get in. So, if this builds and works, we should be 99.9% good to go whenever the release happens.

@Bonkles
Copy link
Contributor Author

Bonkles commented Mar 22, 2023

Created and updated the rapid v2 code to include legacy builds: facebook/Rapid#853.

@tsmock the tag above ⬆️ won't work, it doesn't contain all the correct artifacts. Let me get you a new tag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants