Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISL] Add revert option in inline change view #853

Open
nicktogo opened this issue Mar 14, 2024 · 2 comments
Open

[ISL] Add revert option in inline change view #853

nicktogo opened this issue Mar 14, 2024 · 2 comments

Comments

@nicktogo
Copy link

nicktogo commented Mar 14, 2024 •
edited
Loading

inline change view feature in vscode: https://code.visualstudio.com/updates/v1_18#_inline-change-review
Sapling/ISL doesn't have revert option in this view.
@alex-statsig
Copy link
Contributor

Interestingly you can right click the changed lines and click "Revert this change". I'm not sure why the other revert button doesn't show up / what setting can be enabled to make that work (tried looking into this in the past myself)

@nicktogo
Copy link
Author

Interestingly you can right click the changed lines and click "Revert this change". I'm not sure why the other revert button doesn't show up / what setting can be enabled to make that work (tried looking into this in the past myself)

sometime line level "Revert this change" shows up, sometime it doesn't for me. Are there some tips on how to revert lines/code block easily in using sl or ISL?

facebook-github-bot pushed a commit that referenced this issue Oct 16, 2024
@facebook-github-bot
update itertools 0.12.1 -> 0.13.0
51a884e 
Summary:
# Motivation

And if there is one is one design mistake Rust ecosystem made, it is making [`group_by` weird](rust-itertools/itertools#374) and possible for users to, quote:

> I spent several hours debugging my code written using the group_by function.

Luckily for internal users, the build tooling responds accordingly and fails build for all usages of deprecated API. Thus, there is a need to adjust all of them manually.

# [Release notes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md#0130)

### Breaking
- Removed implementation of `DoubleEndedIterator` for `ConsTuples` (#853)
- Made `MultiProduct` fused and fixed on an empty iterator (#835, #834)
- Changed `iproduct!` to return tuples for maxi one iterator too (#870)
- Changed `PutBack::put_back` to return the old value (#880)
- Removed deprecated `repeat_call, Itertools::{foreach, step, map_results, fold_results}` (#878)
- Removed `TakeWhileInclusive::new` (#912)

NOTE: Quick search didn't tell me anything related to breaking changes above, CI will tell. And, of course, scream to me if it breaks your personal build.

Reviewed By: anps77

Differential Revision: D64306014

fbshipit-source-id: 881ac716e1dc23968d4a28000fdaccdbf9097ec2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicktogo @alex-statsig