Brownfield app crashes when using ReactFragment on new architecture #46566
Comments
|
Have the same issue when just trying to enable New Architecture on existing project. RN 0.75.3 |
cipolleschi
added
the
Type: New Architecture
|
Thanks for attaching a reproducer @gmantuanrosa There is a bug inside |
Thanks to look into it @cortinico! I had the same issue when using Activity as well (also mentioned by @Sky). Probably because they share the same ReactDelegate? Can you say that this will also fix Activity issues? If you want I can update the repro to have a React Activity being launched as well 😄 |
Yes please. I'd say we first need to fix the Activity scenario, and then get back to the Fragment one. If you could update the repo to use activities instead, it would be extremely helpful |
Fortunately I could make it work the Fabric React Activity but there is now an example in the reproducible, I still can't make Fragments work. Also I only got this activity issue once and I don't know how can I reproduce it again. |
|
Ok so sharing my findings so far (perhaps they'll help you @gmantuanrosa) but I need to get back to this next week.
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
String mainComponentName = null;
Bundle launchOptions = null;
Boolean fabricEnabled = null;
if (getArguments() != null) {
mainComponentName = getArguments().getString(ARG_COMPONENT_NAME);
launchOptions = getArguments().getBundle(ARG_LAUNCH_OPTIONS);
fabricEnabled = getArguments().getBoolean(ARG_FABRIC_ENABLED);
}
if (mainComponentName == null) {
throw new IllegalStateException("Cannot loadApp if component name is null");
}
if (!ReactFeatureFlags.enableBridgelessArchitecture) {
mReactDelegate =
new ReactDelegate(
getActivity(), getReactNativeHost(), mainComponentName, launchOptions, fabricEnabled);
} else {
mReactDelegate =
new ReactDelegate(
getActivity(), getReactHost(), mainComponentName, launchOptions);
}
}
private ReactHost getReactHost() {
return ((ReactApplication) getActivity().getApplication()).getReactHost();
}You will then observe that the app crashes with a different crash:
Full stacktrace: I haven't been able to isolate why is it crashing with this error. It can either be because of the Any investigation is more than appreciated @gmantuanrosa |
Description
I have an Android app that is using React Native for some activities and I decided to follow React Native documentation to add into Fragments as well. My App has a mix of XML and Compose navigation and Fragments for the Bottom Tab Navigation -- one of the tab being React Native.
It does work fine until I enable the new architecture, generating app crashes once the Fragment is mounted. I also had the same issue creating a custom Activity with the same crash behavior.
Steps to reproduce
React Native Version
0.75.3
Affected Platforms
Runtime - Android
Output of
npx react-native infoStacktrace or Logs
Reproducer
https://github.com/gmantuanrosa/brownfield-rn-fragment
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: