-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RN][Android] Fix <Image/> Logbox feedback loop #46280
Comments
|
|
@cipolleschi can you please explain more about view preallocation ? |
@deepanshushuklad11 Thanks for the interest in this issue! This is a task I created to mirror an internal task as we are collaborating with another company which is helping with some bugs. Let's leave this to them for the time being! ;) |
@cipolleschi I am not sure if I understand that correctly, but I think that For this code and with activating on bridgeless here, should it technically cause the feedback loop to happen in the current configuration? import { Image, StyleSheet, SafeAreaView } from "react-native";
const IMAGE1 =
'https://www.facebook.com/assets/fb_lite_messaging/[email protected]';
const App = () => {
return (
<SafeAreaView style={styles.container}>
<Image style={styles.image} source={{ uri: IMAGE1 }} />
</SafeAreaView>
)
}
const styles = StyleSheet.create({
container: {
flex: 1,
justifyContent: 'center',
alignItems: 'center',
},
image: {
width: 200,
height: 200,
},
})
export default App; |
@coado As far as I understand, yes, it should happen. But I also think that the warning has been disabled in Bridgeless mode, so that's why you are not seeing it. |
When I remove |
ok, so perhaps this has been fixed somehow by some other fix and the responsible for the task internally forgot to close the task. @RSNara could you help out and double check this? |
Description
When src is null, the
<Image/>
component displays a warning inLogBox
.The feedback loop:
<Image/>
null
src.ReactImageView
receivesnull
src, emits warning.LogBox
, which uses<Image/>
null
src.This feedback loop was originally deactivated in bridgeless.
Why: In step 4, this line would never execute: context.hasActiveReactInstance() would always return false. (
ThemedReactContext
was broken but we fixed it).We should fix this feedback loop, and re-enable this warning in bridgeless.
Hint at a potential fix:
Steps to reproduce
N/A
React Native Version
0.75.2
Affected Platforms
Runtime - Android
Areas
Fabric - The New Renderer
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://github.com/facebook/react-native/packages/rn-tester
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: