From aa89bbd898fcb66433f32f0fd8b259fffda4d287 Mon Sep 17 00:00:00 2001 From: Luna Wei Date: Wed, 15 Mar 2023 14:27:36 -0700 Subject: [PATCH 1/4] Add documentation about breaking change --- docs/textinput.md | 6 ++++++ website/versioned_docs/version-0.71/textinput.md | 10 ++++++++++ 2 files changed, 16 insertions(+) diff --git a/docs/textinput.md b/docs/textinput.md index 5c3f4ffca0d..ec4f480248a 100644 --- a/docs/textinput.md +++ b/docs/textinput.md @@ -853,6 +853,12 @@ Possible values for `textAlign` are: Give the keyboard and the system information about the expected semantic meaning for the content that users enter. +:::note +[`autoComplete`](#autocomplete), provides the same functionality and is available for both platforms. You can use [`Platform.select`](/docs/next/platform#select) for differing platform behaviors. + +Avoid using both `textContentType` and `autoComplete`. For backwards compatibility, when both are set, `textContentType` takes precedence. +::: + For iOS 11+ you can set `textContentType` to `username` or `password` to enable autofill of login details from the device keychain. For iOS 12+ `newPassword` can be used to indicate a new password input the user may want to save in the keychain, and `oneTimeCode` can be used to indicate that a field can be autofilled by a code arriving in an SMS. diff --git a/website/versioned_docs/version-0.71/textinput.md b/website/versioned_docs/version-0.71/textinput.md index 5c3f4ffca0d..864ababca32 100644 --- a/website/versioned_docs/version-0.71/textinput.md +++ b/website/versioned_docs/version-0.71/textinput.md @@ -853,6 +853,16 @@ Possible values for `textAlign` are: Give the keyboard and the system information about the expected semantic meaning for the content that users enter. +:::note +[`autoComplete`](#autocomplete), introduced to iOS in 0.71, provides the same functionality and is available for both platforms. You can use [`Platform.select`](/docs/platform#select) for differing platform behaviors. + +Avoid using both `textContentType` and `autoComplete`. +::: + +:::caution +In 0.71 a breaking change was introduced where the property `autoComplete` overrides `textContentType` on iOS when both are set. In 0.71.5, this was addressed so that `textContentType` takes precedence. +::: + For iOS 11+ you can set `textContentType` to `username` or `password` to enable autofill of login details from the device keychain. For iOS 12+ `newPassword` can be used to indicate a new password input the user may want to save in the keychain, and `oneTimeCode` can be used to indicate that a field can be autofilled by a code arriving in an SMS. From e2384c17be193f7ffa5202e8250fe8198a9235b9 Mon Sep 17 00:00:00 2001 From: Luna Wei Date: Wed, 15 Mar 2023 14:42:34 -0700 Subject: [PATCH 2/4] Better wording --- docs/textinput.md | 2 +- website/versioned_docs/version-0.71/textinput.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/textinput.md b/docs/textinput.md index ec4f480248a..c4bb5b77b68 100644 --- a/docs/textinput.md +++ b/docs/textinput.md @@ -856,7 +856,7 @@ Give the keyboard and the system information about the expected semantic meaning :::note [`autoComplete`](#autocomplete), provides the same functionality and is available for both platforms. You can use [`Platform.select`](/docs/next/platform#select) for differing platform behaviors. -Avoid using both `textContentType` and `autoComplete`. For backwards compatibility, when both are set, `textContentType` takes precedence. +Avoid using both `textContentType` and `autoComplete`. For backwards compatibility, `textContentType` takes precedence when both properties are set. ::: For iOS 11+ you can set `textContentType` to `username` or `password` to enable autofill of login details from the device keychain. diff --git a/website/versioned_docs/version-0.71/textinput.md b/website/versioned_docs/version-0.71/textinput.md index 864ababca32..5bd14001605 100644 --- a/website/versioned_docs/version-0.71/textinput.md +++ b/website/versioned_docs/version-0.71/textinput.md @@ -860,7 +860,7 @@ Avoid using both `textContentType` and `autoComplete`. ::: :::caution -In 0.71 a breaking change was introduced where the property `autoComplete` overrides `textContentType` on iOS when both are set. In 0.71.5, this was addressed so that `textContentType` takes precedence. +A breaking change was introduced in 0.71 where `autoComplete` overrides `textContentType` on iOS when both properties are set. >=0.71.5 reverts the breaking change such that `textContentType` takes precedence. ::: For iOS 11+ you can set `textContentType` to `username` or `password` to enable autofill of login details from the device keychain. From 95fb3be3c907a609da3b3e72e06593d9fbdbfdf6 Mon Sep 17 00:00:00 2001 From: Luna Date: Fri, 17 Mar 2023 13:40:54 -0700 Subject: [PATCH 3/4] Update docs/textinput.md --- docs/textinput.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/textinput.md b/docs/textinput.md index c4bb5b77b68..590ff1f5d83 100644 --- a/docs/textinput.md +++ b/docs/textinput.md @@ -854,7 +854,7 @@ Possible values for `textAlign` are: Give the keyboard and the system information about the expected semantic meaning for the content that users enter. :::note -[`autoComplete`](#autocomplete), provides the same functionality and is available for both platforms. You can use [`Platform.select`](/docs/next/platform#select) for differing platform behaviors. +[`autoComplete`](#autocomplete), provides the same functionality and is available for all platforms. You can use [`Platform.select`](/docs/next/platform#select) for differing platform behaviors. Avoid using both `textContentType` and `autoComplete`. For backwards compatibility, `textContentType` takes precedence when both properties are set. ::: From b75d49595c168ecfa2d359312cecdba0415e85cb Mon Sep 17 00:00:00 2001 From: Luna Date: Fri, 17 Mar 2023 13:41:00 -0700 Subject: [PATCH 4/4] Update website/versioned_docs/version-0.71/textinput.md --- website/versioned_docs/version-0.71/textinput.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/versioned_docs/version-0.71/textinput.md b/website/versioned_docs/version-0.71/textinput.md index 5bd14001605..60e73ecdd81 100644 --- a/website/versioned_docs/version-0.71/textinput.md +++ b/website/versioned_docs/version-0.71/textinput.md @@ -854,7 +854,7 @@ Possible values for `textAlign` are: Give the keyboard and the system information about the expected semantic meaning for the content that users enter. :::note -[`autoComplete`](#autocomplete), introduced to iOS in 0.71, provides the same functionality and is available for both platforms. You can use [`Platform.select`](/docs/platform#select) for differing platform behaviors. +[`autoComplete`](#autocomplete), introduced to iOS in 0.71, provides the same functionality and is available for all platforms. You can use [`Platform.select`](/docs/platform#select) for differing platform behaviors. Avoid using both `textContentType` and `autoComplete`. :::