Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include mandatory passing of props for components that wrap RefreshControll #4455

Open
shoshkovnexo opened this issue Jan 23, 2025 · 0 comments

Comments

@shoshkovnexo
Copy link

Description

The RefreshControl documentation doesn't mention that when the component is wrapped in a custom compoent it needs props passed so that it doesn't break on Android.

What is the problem?

If you have a component like this

<Container
......
refreshControl={}

the dev has no way to know that the refreshControll prop returns props that need to be passed down to the RefreshControl in you custom component in order for it to work on Android.

We fixed it by passing props to the custom component and then to RefreshControll. This issue was present only on Android and it was breaking the entire screen.

How can we address it?

Include a note in the RefreshControl documentation that mentions this issue.

Why is it important?

This will save debugging time for developers.

Who needs this?

Devs developing for Android

When should this happen (use version numbers if needed)

This isn't time sensitive but the sooner - the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant