diff --git a/front_end/panels/console/ConsolePrompt.ts b/front_end/panels/console/ConsolePrompt.ts index bad4e869b96..8787b7c8cc3 100644 --- a/front_end/panels/console/ConsolePrompt.ts +++ b/front_end/panels/console/ConsolePrompt.ts @@ -53,7 +53,8 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin; + // TODO(T225263604): Restore this setting + // private readonly eagerEvalSetting: Common.Settings.Setting; private previewRequestForTest: Promise|null; private highlightingNode: boolean; // The CodeMirror state field that controls whether the argument hints are showing. @@ -112,9 +113,11 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin; private readonly consoleHistoryAutocompleteSetting: Common.Settings.Setting; private selfXssWarningDisabledSetting: Common.Settings.Setting; - readonly pinPane: ConsolePinPane; + // TODO(T225263604): Restore Live Expressions panel + // readonly pinPane: ConsolePinPane; private viewport: ConsoleViewport; private messagesElement: HTMLElement; private messagesCountElement: HTMLElement; @@ -406,8 +407,9 @@ export class ConsoleView extends UI.Widget.VBox implements toolbar.appendSeparator(); toolbar.appendToolbarItem(this.consoleContextSelector.toolbarItem()); toolbar.appendSeparator(); - const liveExpressionButton = UI.Toolbar.Toolbar.createActionButtonForId('console.create-pin'); - toolbar.appendToolbarItem(liveExpressionButton); + // TODO(T225263604): Restore Live Expressions panel + // const liveExpressionButton = UI.Toolbar.Toolbar.createActionButtonForId('console.create-pin'); + // toolbar.appendToolbarItem(liveExpressionButton); toolbar.appendSeparator(); toolbar.appendToolbarItem(this.filter.textFilterUI); toolbar.appendToolbarItem(this.filter.levelMenuButton); @@ -468,8 +470,9 @@ export class ConsoleView extends UI.Widget.VBox implements ConsoleView.appendSettingsCheckboxToToolbar( settingsToolbarRight, monitoringXHREnabledSetting, i18nString(UIStrings.logXMLHttpRequests)); - ConsoleView.appendSettingsCheckboxToToolbar( - settingsToolbarRight, 'console-eager-eval', i18nString(UIStrings.eagerlyEvaluateTextInThePrompt)); + // TODO(T225263604): Restore this setting + // ConsoleView.appendSettingsCheckboxToToolbar( + // settingsToolbarRight, 'console-eager-eval', i18nString(UIStrings.eagerlyEvaluateTextInThePrompt)); ConsoleView.appendSettingsCheckboxToToolbar( settingsToolbarRight, this.consoleHistoryAutocompleteSetting, i18nString(UIStrings.autocompleteFromHistory)); ConsoleView.appendSettingsCheckboxToToolbar( @@ -481,9 +484,10 @@ export class ConsoleView extends UI.Widget.VBox implements this.showSettingsPaneSetting.addChangeListener( () => settingsPane.element.classList.toggle('hidden', !this.showSettingsPaneSetting.get())); - this.pinPane = new ConsolePinPane(liveExpressionButton, () => this.prompt.focus()); - this.pinPane.element.classList.add('console-view-pinpane'); - this.pinPane.show(this.contentsElement); + // TODO(T225263604): Restore Live Expressions panel + // this.pinPane = new ConsolePinPane(liveExpressionButton, () => this.prompt.focus()); + // this.pinPane.element.classList.add('console-view-pinpane'); + // this.pinPane.show(this.contentsElement); this.viewport = new ConsoleViewport(this); this.viewport.setStickToBottom(true); @@ -1827,9 +1831,10 @@ export class ActionDelegate implements UI.ActionRegistration.ActionDelegate { case 'console.clear.history': ConsoleView.instance().clearHistory(); return true; - case 'console.create-pin': - ConsoleView.instance().pinPane.addPin('', true /* userGesture */); - return true; + // TODO(T225263604): Restore Live Expressions panel + // case 'console.create-pin': + // ConsoleView.instance().pinPane.addPin('', true /* userGesture */); + // return true; } return false; } diff --git a/front_end/panels/console/console-meta.ts b/front_end/panels/console/console-meta.ts index b41918397d8..a68fc55c168 100644 --- a/front_end/panels/console/console-meta.ts +++ b/front_end/panels/console/console-meta.ts @@ -229,16 +229,17 @@ UI.ActionRegistration.registerActionExtension({ }, }); -UI.ActionRegistration.registerActionExtension({ - actionId: 'console.create-pin', - category: UI.ActionRegistration.ActionCategory.CONSOLE, - title: i18nLazyString(UIStrings.createLiveExpression), - iconClass: UI.ActionRegistration.IconClass.EYE, - async loadActionDelegate() { - const Console = await loadConsoleModule(); - return new Console.ConsoleView.ActionDelegate(); - }, -}); +// TODO(T225263604): Restore Live Expressions panel +// UI.ActionRegistration.registerActionExtension({ +// actionId: 'console.create-pin', +// category: UI.ActionRegistration.ActionCategory.CONSOLE, +// title: i18nLazyString(UIStrings.createLiveExpression), +// iconClass: UI.ActionRegistration.IconClass.EYE, +// async loadActionDelegate() { +// const Console = await loadConsoleModule(); +// return new Console.ConsoleView.ActionDelegate(); +// }, +// }); Common.Settings.registerSettingExtension({ category: Common.Settings.SettingCategory.CONSOLE, @@ -380,24 +381,25 @@ Common.Settings.registerSettingExtension({ ], }); -Common.Settings.registerSettingExtension({ - category: Common.Settings.SettingCategory.CONSOLE, - storageType: Common.Settings.SettingStorageType.Synced, - title: i18nLazyString(UIStrings.eagerEvaluation), - settingName: 'console-eager-eval', - settingType: Common.Settings.SettingType.BOOLEAN, - defaultValue: true, - options: [ - { - value: true, - title: i18nLazyString(UIStrings.eagerlyEvaluateConsolePromptText), - }, - { - value: false, - title: i18nLazyString(UIStrings.doNotEagerlyEvaluateConsole), - }, - ], -}); +// TODO(T225263604): Restore this setting +// Common.Settings.registerSettingExtension({ +// category: Common.Settings.SettingCategory.CONSOLE, +// storageType: Common.Settings.SettingStorageType.Synced, +// title: i18nLazyString(UIStrings.eagerEvaluation), +// settingName: 'console-eager-eval', +// settingType: Common.Settings.SettingType.BOOLEAN, +// defaultValue: true, +// options: [ +// { +// value: true, +// title: i18nLazyString(UIStrings.eagerlyEvaluateConsolePromptText), +// }, +// { +// value: false, +// title: i18nLazyString(UIStrings.doNotEagerlyEvaluateConsole), +// }, +// ], +// }); Common.Settings.registerSettingExtension({ category: Common.Settings.SettingCategory.CONSOLE,