Skip to content

Commit ee74ba3

Browse files
grievejiafacebook-github-bot
authored andcommitted
Avoid crashing the server when fast incremental build fails on buck query
Reviewed By: dkgi Differential Revision: D30529461 fbshipit-source-id: ac1923743055652e317a45c8ea6e3844d434a6c4
1 parent c40ee9e commit ee74ba3

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

source/buck/builder.ml

+3
Original file line numberDiff line numberDiff line change
@@ -477,6 +477,9 @@ let compute_difference_from_changed_paths ~source_root ~buck_options ~targets ch
477477
|> Lwt.return_ok
478478
with
479479
| JsonError message -> Lwt.return_error message
480+
| Raw.BuckError { description; _ } ->
481+
let message = Format.sprintf "Buck query failed: %s" description in
482+
Lwt.return_error message
480483

481484

482485
let build_map_and_difference_from_paths

0 commit comments

Comments
 (0)