Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a lint for missing flow types #7151

Open
etrepum opened this issue Feb 8, 2025 · 1 comment
Open

Feature: Add a lint for missing flow types #7151

etrepum opened this issue Feb 8, 2025 · 1 comment
Labels
enhancement Improvement over existing feature

Comments

@etrepum
Copy link
Collaborator

etrepum commented Feb 8, 2025

Description

Most of the flow types are nearly trivial copy and paste jobs from the typescript exports, but it's hard to know what types are missing because we don't have any tooling assistance for them.

It's probably not reasonable to ask all contributors to learn flow, but having an easy way to know if flow types are missing before a release.

Should be fairly straightforward to use the TypeScript and hermes APIs to get the names of each export from the modules.

Impact

Probably only really helps Meta, not sure if there are any other lexical users that use flow, but doing these sorts of updates in bulk would reduce the PR review burden a bit.

@etrepum etrepum added the enhancement Improvement over existing feature label Feb 8, 2025
@etrepum
Copy link
Collaborator Author

etrepum commented Feb 14, 2025

Related #7148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement over existing feature
Projects
None yet
Development

No branches or pull requests

1 participant