-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined symbols for architecture x86_64 (glog), w/ use_frameworks!, Hermes #3861
Comments
I'm dealing with a similar issue. Here's a quote from https://rnfirebase.io/ "Note use_frameworks is not compatible with Flipper, Hermes, React Native New Architecture or react-native 0.69.0. There is already a patch-package patch available for 0.69.0 that makes it work with and without Hermes and it will be released with 0.69.1. Community support to help fix use_frameworks support for Hermes and New Architecture is welcome!" It looks like they just released 0.69.1 a few hours ago, but according to other posts in react-native issues it looks like now there are different issues with installing libraries at facebook/react-native#34101 (comment) and facebook/react-native#34102. |
@annieneedscoffee |
I guess not for now. I think they're still working on the fix. I'm going to check back in a few days and see if they have provided an update. |
I'm seeing the same errors here with basically the same |
@Kudo apologies for just randomly tagging you in on an issue, but this is the build error stopping Flipper from working with use_frameworks. There's confirmation of the same here invertase/react-native-firebase#6425 (comment) Perhaps you have the wisdom to know semi-immediately what this type of error usually means and how to fix it. I see it as a likely linker path issue, but I'm not sure exactly how to fix The Podfile above looks like it matches the documentation in this repo https://fbflipper.com/docs/getting-started/ios-native/#cocoapods So this is the leading edge of "getting use_frameworks working in the main react-native components", if this can be fixed I'll be in the area off and on giving it a shot myself, but you sniped the Hermes issue so quickly I couldn't resist tagging you. Cheers |
@mikehardy i'm afraid i can help here. as far as i know flipper doesn't support use_frameworks from very early days. i tried to fix some but there're many issues, e.g. incorrect double quoted imports. i think to support use_frameworks for flipper. the source code and podspecs should be reorganized much just like the case of use_frameworks + fabric. |
That background info (that you tried, and what the real scope of solution is), is still great information, thanks @Kudo. Flipper team, the documentation currently states how to get use_frameworks to work on Flipper but those documents do not result in a successful build. Is this on your radar at all for a fix? My motivation is that react-native-firebase requires use_frameworks now, and I'd like to get this to work out of the box for people. Going by npmjs stats we appear to represent about 25% of all react-native usage (266K/week vs 1000K/week) so perhaps it is worth a look? |
@mikehardy It doesn't seem like issues on this repo get regularly checked by anyone, perhaps it would get some attention if linked to an issue on the main react-native repo? |
I'll bring it up on discord and see what happens |
For what it's worth, I did bring this up on discord () and the response for the moment is that the team is aware and it needs effort, but there does not appear to be a commitment to a deadline or anything. So this may sit for a while |
Bummer, I am experiencing the same issue. Looks like I will no longer use flipper in React Native iOS app for a while... |
Facing same issue for IOS in React-Native after upgrading to 0.70 and enabling useFrameworks! :linkage => :static (https://rnfirebase.io/). |
@sairajKalkundre Flipper does not work with any form of For future readers: until you see some discussion of a patch to try, or you are proposing a patch to try, Flipper will simply not work with use_frameworks and of course you will experience the same issue. Posting the same is a sort of "metoo" and is best handled as a reaction (thumbs up or similar) on this issue itself, way up at the top. Thanks |
@mikehardy I have edited my comment. |
@sairajKalkundre have you been albe to fix this irritating issue? |
Temporary workaround from another thread: |
🐛 Bug Report
When I build my react-native app with Xcode I get the following error.
I seem to be getting an error about glog in NotificationService, which is Dependencies in myapp.
To Reproduce
I have enabled use_frameworks! (dependent library constraints), Hermes and Flipper are also enabled.
Podfile (excerpt) ↓. I have also added some workarounds in reference to other issues.
install pods and build RN app with xcode.
Environment
M1 pro
Flipper Desktop version: 0.150.0
XCode version: 13.3
react: 17.0.2
react-native: 0.66.3
flipperkit version in Pods: 0.150.0
The text was updated successfully, but these errors were encountered: