From d9258eb755c9a06962ea86e7bea3b39bebd34d19 Mon Sep 17 00:00:00 2001 From: Anton Kastritskiy Date: Fri, 28 Jun 2024 09:14:40 -0700 Subject: [PATCH] fix idb_companion detection Summary: * `idb_companion` is snake case * `idb_companion --help` exists with non-zero exit code, thus using `which` instead Reviewed By: LukeDefeo Differential Revision: D59162166 fbshipit-source-id: 0d4917339a846493735804155af8178a904f15e8 --- desktop/doctor/src/index.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/desktop/doctor/src/index.tsx b/desktop/doctor/src/index.tsx index 5311dfdb550..d0fcc5ff582 100644 --- a/desktop/doctor/src/index.tsx +++ b/desktop/doctor/src/index.tsx @@ -188,8 +188,6 @@ export function getHealthchecks( const result = await tryExecuteCommand( `${settings?.idbPath} --help`, ); - const hasIdbCompanion = - await tryExecuteCommand(`idbCompanion --help`); if (result.fail) { const hasIdbInPath = await tryExecuteCommand(`which idb`); @@ -205,6 +203,9 @@ export function getHealthchecks( ], }; } + const hasIdbCompanion = await tryExecuteCommand( + 'which idb_companion', + ); return { hasProblem: true,