From 438b9b07dafd6870c8bcd39b2ce5cd8a11252f4b Mon Sep 17 00:00:00 2001 From: Yasser Tahiri Date: Tue, 3 Oct 2023 13:39:37 -0700 Subject: [PATCH] =?UTF-8?q?feat:=20Us=20e=20`with`=20when=20opening=20file?= =?UTF-8?q?=20to=20ensure=20closure=20=E2=9C=A8=20(#604)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Pull Request resolved: https://github.com/facebook/facebook-python-business-sdk/pull/604 Reviewed By: mengxuanzhangz Differential Revision: D49881089 Pulled By: stcheng fbshipit-source-id: c43169f1924b9336352e029e952da91311f019de --- examples/async.py | 6 ++---- examples/batch_create.py | 7 +++---- examples/batch_pause.py | 7 +++---- examples/custom_audience_utils.py | 8 +++----- examples/dpa-update/dpa_search.py | 6 ++---- examples/dpa-update/dpa_update.py | 6 ++---- examples/read_objects.py | 7 +++---- examples/simple_create.py | 18 ++++++++---------- examples/upload_video.py | 7 +++---- 9 files changed, 29 insertions(+), 43 deletions(-) diff --git a/examples/async.py b/examples/async.py index 203e7129f..e7d955699 100644 --- a/examples/async.py +++ b/examples/async.py @@ -33,10 +33,8 @@ this_dir = os.path.dirname(__file__) config_filename = os.path.join(this_dir, 'config.json') -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) api = FacebookAdsApi.init(access_token=config['access_token']) account_id = config['act_id'] diff --git a/examples/batch_create.py b/examples/batch_create.py index 42d00eebe..225c3e552 100644 --- a/examples/batch_create.py +++ b/examples/batch_create.py @@ -22,6 +22,7 @@ Creates several ads using batch calls. """ + from facebook_business import FacebookSession from facebook_business import FacebookAdsApi from facebook_business.adobjects.adaccount import AdAccount @@ -35,10 +36,8 @@ this_dir = os.path.dirname(__file__) config_filename = os.path.join(this_dir, 'config.json') -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) ### Setup session and api objects session = FacebookSession( config['app_id'], diff --git a/examples/batch_pause.py b/examples/batch_pause.py index d46e13192..71f877931 100644 --- a/examples/batch_pause.py +++ b/examples/batch_pause.py @@ -22,6 +22,7 @@ Pauses all active ad campaigns using batch calls. """ + from facebook_business import FacebookSession from facebook_business import FacebookAdsApi from facebook_business.adobjects.adaccount import AdAccount @@ -35,10 +36,8 @@ this_dir = os.path.dirname(__file__) config_filename = os.path.join(this_dir, 'config.json') -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) ### Setup session and api objects session = FacebookSession( config['app_id'], diff --git a/examples/custom_audience_utils.py b/examples/custom_audience_utils.py index b35804c26..b38992d1c 100644 --- a/examples/custom_audience_utils.py +++ b/examples/custom_audience_utils.py @@ -24,6 +24,7 @@ https://github.com/facebook/facebook-python-ads-sdk """ + from facebook_business import FacebookAdsApi from facebook_business.adobjects.adaccount import AdAccount from facebook_business.adobjects.customaudience import CustomAudience @@ -38,11 +39,8 @@ this_dir = os.path.dirname(__file__) config_filename = os.path.join(this_dir, 'config.json') -### Setup session and api objects -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) auth_info = ( config['app_id'], config['app_secret'], diff --git a/examples/dpa-update/dpa_search.py b/examples/dpa-update/dpa_search.py index 8f5614439..419ec76a0 100644 --- a/examples/dpa-update/dpa_search.py +++ b/examples/dpa-update/dpa_search.py @@ -29,10 +29,8 @@ import sys sys.path.insert(1, os.path.join(this_dir, os.pardir, os.pardir)) -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) from facebook_business.api import FacebookAdsApi from facebook_business.adobjects.productcatalog import ProductCatalog from facebook_business.adobjects.productitem import ProductItem diff --git a/examples/dpa-update/dpa_update.py b/examples/dpa-update/dpa_update.py index e70dd5e0a..c2e45016c 100644 --- a/examples/dpa-update/dpa_update.py +++ b/examples/dpa-update/dpa_update.py @@ -30,10 +30,8 @@ import sys sys.path.insert(1, os.path.join(this_dir, os.pardir, os.pardir)) -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) from facebook_business.api import FacebookAdsApi from facebook_business.adobjects.productcatalog import ProductCatalog from facebook_business.adobjects.productitem import ProductItem diff --git a/examples/read_objects.py b/examples/read_objects.py index 20306907b..aceed992c 100644 --- a/examples/read_objects.py +++ b/examples/read_objects.py @@ -22,6 +22,7 @@ Prints account permissions and campaign statistics. """ + from facebook_business import FacebookSession from facebook_business import FacebookAdsApi from facebook_business.adobjects.campaign import Campaign as AdCampaign @@ -35,10 +36,8 @@ this_dir = os.path.dirname(__file__) config_filename = os.path.join(this_dir, 'config.json') -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) ### Setup session and api objects session = FacebookSession( config['app_id'], diff --git a/examples/simple_create.py b/examples/simple_create.py index 692d8e2a5..e7d26f720 100644 --- a/examples/simple_create.py +++ b/examples/simple_create.py @@ -22,6 +22,7 @@ Creates an ad through a utility function. """ + from facebook_business import FacebookSession from facebook_business import FacebookAdsApi from facebook_business.adobjects.adaccount import AdAccount @@ -36,10 +37,8 @@ this_dir = os.path.dirname(__file__) config_filename = os.path.join(this_dir, 'config.json') -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) ### Setup session and api objects session = FacebookSession( config['app_id'], @@ -88,10 +87,9 @@ 'ad_format': AdPreview.AdFormat.right_column_standard }) preview_filename = os.path.join(this_dir, 'preview_ad.html') - preview_file = open(preview_filename, 'w') - preview_file.write( - "Facebook Ad Preview%s" - % preview.get_html() - ) - preview_file.close() + with open(preview_filename, 'w') as preview_file: + preview_file.write( + "Facebook Ad Preview%s" + % preview.get_html() + ) print('**** %s has been created!' % preview_filename) diff --git a/examples/upload_video.py b/examples/upload_video.py index c4482f8a0..905c64bfd 100644 --- a/examples/upload_video.py +++ b/examples/upload_video.py @@ -22,6 +22,7 @@ Upload a video to adaccount """ + import sys import os @@ -34,10 +35,8 @@ config_filename = os.path.join(sdk_path, './config.json') -config_file = open(config_filename) -config = json.load(config_file) -config_file.close() - +with open(config_filename) as config_file: + config = json.load(config_file) ### Setup session and api objects session = FacebookSession( config['app_id'],