Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKTextComponent and links again #756

Open
RomanTruba opened this issue Feb 15, 2017 · 5 comments
Open

CKTextComponent and links again #756

RomanTruba opened this issue Feb 15, 2017 · 5 comments

Comments

@RomanTruba
Copy link

Hi guys.
#246 , #253 says it is possible to get link pressed by almost hacking: accessing CKTextComponentView renderer and then getting link from it.
But the fact is CKTextComponentView.h now project-level header, and now it is impossible to access it from my code.
Maybe it is time now to implement the feature "Which link was exactly pressed"?

@ocrickard
Copy link
Contributor

Sure, we're open to pull requests!

@ocrickard
Copy link
Contributor

I think a really nice PR here would be to provide a CKTypedComponentAction form of touch up action.

@ocrickard
Copy link
Contributor

@nscoding what do you think of open sourcing the internal text component? I'm tired of maintaining two stacks.

@serjiogunit
Copy link

Hello, any updates here? How to detect tapped link?

@fabiomassimo
Copy link
Contributor

Sorry for this being around for a while.
We have recently discussed this again with the team and we decided to not add new features to the CKTextComponentView as it is right now but rather work on releasing a new text component that we have built internally.
As soon we have a rough ETA we will update this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants