Skip to content

Commit b230cdf

Browse files
Hao Wufacebook-github-bot
Hao Wu
authored andcommitted
Carry over counter type correctly
Summary: We missed the counter type here and all driver (blockcache/bighash) counters are COUNT. This diff fixes it. Reviewed By: therealgymmy Differential Revision: D70584174 fbshipit-source-id: 4da9839ffe2f2bd4acea7025f7b4eb49fd46da85
1 parent e7b4ee2 commit b230cdf

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

cachelib/navy/driver/Driver.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -330,10 +330,11 @@ void Driver::getCounters(const CounterVisitor& visitor) const {
330330
? ""
331331
: folly::to<std::string>(":", enginePairs_[idx].getName());
332332

333-
const CounterVisitor pv{
334-
[&visitor, idx, &suffix](folly::StringPiece name, double count) {
335-
visitor(folly::to<std::string>(name, "_", idx, suffix), count);
336-
}};
333+
const CounterVisitor pv{[&visitor, idx,
334+
&suffix](folly::StringPiece name, double count,
335+
CounterVisitor::CounterType type) {
336+
visitor(folly::to<std::string>(name, "_", idx, suffix), count, type);
337+
}};
337338
enginePairs_[idx].getCounters(pv);
338339

339340
visitor(folly::to<std::string>("navy_rejected_", idx, suffix),

0 commit comments

Comments
 (0)