fix various warning violations under llvm-19

yfeldblum · facebook-github-bot · commit 6e3d6f6750bb · 2025-02-21T09:07:25.000-08:00
Reviewed By: therealgymmy

Differential Revision: D69936856

fbshipit-source-id: 92dbfaf474ee0ed546b0edcbb56adb3704159d80
diff --git a/cachelib/common/Serialization.h b/cachelib/common/Serialization.h
@@ -186,7 +186,7 @@ std::unique_ptr<RecordReader> createMemoryRecordReader(
 template <typename ThriftObject, typename SerializationProto>
 void serializeProto(const ThriftObject& obj, RecordWriter& writer) {
   folly::IOBufQueue temp;
-  SerializationProto::template serialize(obj, &temp);
+  SerializationProto::serialize(obj, &temp);
   // Passes linked chain of IOBufs
   writer.writeRecord(temp.move());
 }
diff --git a/cachelib/common/tests/SerializationTest.cpp b/cachelib/common/tests/SerializationTest.cpp
@@ -40,7 +40,7 @@ TEST(Serializer, InvalidSerialization) {
   {
     const size_t smallSize = bytesUsed / 2;
     ASSERT_LT(smallSize, bytesUsed);
-    uint8_t smallBuf[smallSize];
+    uint8_t smallBuf[SerializationBufferSize];
     Serializer s2(&smallBuf[0], &smallBuf[smallSize - 1]);
     ASSERT_THROW(s2.serialize(m), std::exception);
   }

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ std::unique_ptr<RecordReader> createMemoryRecordReader(`
`186`	`186`	`template <typename ThriftObject, typename SerializationProto>`
`187`	`187`	`void serializeProto(const ThriftObject& obj, RecordWriter& writer) {`
`188`	`188`	`folly::IOBufQueue temp;`
`189`		`- SerializationProto::template serialize(obj, &temp);`
	`189`	`+ SerializationProto::serialize(obj, &temp);`
`190`	`190`	`// Passes linked chain of IOBufs`
`191`	`191`	`writer.writeRecord(temp.move());`
`192`	`192`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ TEST(Serializer, InvalidSerialization) {`
`40`	`40`	`{`
`41`	`41`	`const size_t smallSize = bytesUsed / 2;`
`42`	`42`	`ASSERT_LT(smallSize, bytesUsed);`
`43`		`- uint8_t smallBuf[smallSize];`
	`43`	`+ uint8_t smallBuf[SerializationBufferSize];`
`44`	`44`	`Serializer s2(&smallBuf[0], &smallBuf[smallSize - 1]);`
`45`	`45`	`ASSERT_THROW(s2.serialize(m), std::exception);`
`46`	`46`	`}`