Add should_skip setting to input constructors #2894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64475782 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 16, 2024
Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node Following diffs will: - update the gs to appropiately handle resetting to false after a gen is completed Differential Revision: D64475782
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 17, 2024
Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node Following diffs will: - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64475782
mgarrard
force-pushed
the
export-D64475782
branch
from
9bb01e3
to
f616efa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64475782 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 17, 2024
Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node Following diffs will: - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64475782
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 504 504
Lines 49790 49806 +16
=======================================
+ Hits 47692 47708 +16
Misses 2098 2098 ☔ View full report in Codecov by Sentry. |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 17, 2024
Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node Following diffs will: - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64475782
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 17, 2024
Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node Following diffs will: - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64475782
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 17, 2024
Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node Following diffs will: - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64475782
Summary: There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generaiton strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. This simply exposes a prop on gen node to expose this, and default it to false Following diffs will: - update TC.is_met() to accept a GenNode instead of just the name - update input constructor to properly set should skip - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64444258
…ebook#2893) Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** updates tc.is_met() to accept a full generation node which allows us to access the should_skip property we added in the previous diff Following diffs will: - update input constructor to properly set should skip - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64445871
Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node Following diffs will: - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64475782
mgarrard
force-pushed
the
export-D64475782
branch
from
f616efa
to
791b95f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64475782 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 17, 2024
Summary: **Context:** There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node. **This diff** adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node Following diffs will: - update the gs to appropiately handle resetting to false after a gen is completed Reviewed By: lena-kashtelyan Differential Revision: D64475782
|
This pull request has been merged in a6ce2c3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: There are some cases where the input constructor returns n=o, specifically for repeat arms, this is currently causing an issue in generation strategy gen method because if we don't generate from a node we can't meet the TC, and move forward, however, we don't actually want to generate from that node.
This diff adds the setting of should skip to repeat_arm_n input constructor as it's currently the only input constructor that could enter a condition that creates a skippable node
Following diffs will:
Differential Revision: D64475782