You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A few thoughts/suggestions about the code readability:
I see that you have moved some of your functions outside of your App component to make it more modularised 🙌. An additional suggestion would be to put your components in their own folder, nested in src. You could also put the 'helper' function files into their own file/folder (e.g helpers or utils). These conventions are not strict rules, but as your project grows it makes it easy for developers to find and reuse the extracted functions.
You seem to have created a function that simply calls another function with the same parameters here in gameLoop.js 👀:
Passing props. A small thing, but you have passed props in differing ways. The cohort debated whether to destructure props but, even if a stylistic choice has been made not to, this is maybe a good prompt to think about consistency and what makes the code most readable to other developers. Just food for thought 🤔....
For Hero you have passed/used it like this:
For Villain and Projectile you have passed/used it like so:
The text was updated successfully, but these errors were encountered:
A few thoughts/suggestions about the code readability:
I see that you have moved some of your functions outside of your App component to make it more modularised 🙌. An additional suggestion would be to put your components in their own folder, nested in src. You could also put the 'helper' function files into their own file/folder (e.g helpers or utils). These conventions are not strict rules, but as your project grows it makes it easy for developers to find and reuse the extracted functions.
You seem to have created a function that simply calls another function with the same parameters here in gameLoop.js 👀:
For Hero you have passed/used it like this:
![image](https://private-user-images.githubusercontent.com/60395899/246026296-58034229-10e9-48da-8297-c83948f6843d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3NjM5NjAsIm5iZiI6MTczODc2MzY2MCwicGF0aCI6Ii82MDM5NTg5OS8yNDYwMjYyOTYtNTgwMzQyMjktMTBlOS00OGRhLTgyOTctYzgzOTQ4ZjY4NDNkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDEzNTQyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5MmYyODE0YzBjYjgwN2U1MmIwN2M3ODNjZjQ3MTNiYzA0Nzg2MzJhZWJlNDE5N2I2MGEzNjM2ZDU0ZjNhZjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.C12TFryawHSbWT7A1MlsodeUe2d9q4dnSw1PgFjCuTE)
For Villain and Projectile you have passed/used it like so:
![image](https://private-user-images.githubusercontent.com/60395899/246025995-6090ec9f-c7c9-4b3c-8bcc-88ef92fa7243.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3NjM5NjAsIm5iZiI6MTczODc2MzY2MCwicGF0aCI6Ii82MDM5NTg5OS8yNDYwMjU5OTUtNjA5MGVjOWYtYzdjOS00YjNjLThiY2MtODhlZjkyZmE3MjQzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDEzNTQyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM2ZmMxMDQ5N2Q0OTVkNmM1ZGQ0ZjgxNjBkZDgyYzZhOGU0N2Y4MDRhZTgwNWJjODBmZjY5OGU4OTE2MmUyNDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lK_vCFRryw6tNRHQmUwpEN0nRbTVreBs4zm60FVwRIY)
The text was updated successfully, but these errors were encountered: