Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Some duplicates ending up in responses object for checkbox questions #148

Open
freemvmt opened this issue Apr 1, 2020 · 1 comment
Open

BUG: Some duplicates ending up in responses object for checkbox questions #148

freemvmt opened this issue Apr 1, 2020 · 1 comment
Assignees
@freemvmt
Labels
bug Something isn't working E1

Comments

@freemvmt
Copy link
Collaborator

freemvmt commented Apr 1, 2020 •
edited
Loading

Only seems to happen when other submission is included (navigate away and back to see this).

Check reducer functionality for this case.
@freemvmt freemvmt self-assigned this Apr 1, 2020
@freemvmt freemvmt added bug Something isn't working E1 labels Apr 1, 2020
@freemvmt freemvmt changed the title BUG: Some duplicates ending up in responses object for checkbox questions (only happens when other submission included) BUG: Some duplicates ending up in responses object for checkbox questions Apr 1, 2020
@freemvmt
Copy link
Collaborator Author

freemvmt commented Apr 2, 2020

Fix: swapped 1st and 2nd branches in checkbox branch of reducer (hadn't anticipated that the re-selection of checkboxes other than the 'Other' option would also be non-trusted events i.e. programmatically rather than user generated)

freemvmt pushed a commit that referenced this issue Apr 2, 2020
edit reducer to fix bug resulting in duplicates ending up in the resp…
128ea47 
…onses object for checkbox questions

Relates #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freemvmt freemvmt

Labels
bug Something isn't working E1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@freemvmt