-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: <FabricImage>.fromURL() simply does not work. #9992
Comments
Update: I've tested this on v6.0.2, v6.0.1, v6.0.1, and even v6.0.0-beta1. They all didn't work. |
Callback methods has been removed from v6 as said on breaking changes issue : #8299 You can load image like that :
|
Please read at least this one before starting working with 6.0, fabricjs.github.io will be the new fabricjs.com as soon as is in a decent shape |
Makes sense, I saw that "upgrading to fabric" changelog and noticed that, but I assumed that if I tried to do it like that it just wouldn't work because none of the docs, tutorials, or demos were like that. I also couldn't find any fabric code out there using promises on github (sourcegraph - guess I'm bad at querying), and I just assumed since the stable v6 came out 2 weeks ago and the v6 beta came out 5 months, that the docs would've been updated by now. My bad, apologies for the false positive. 👍 |
CheckList
Version
6.0.2
In What environments are you experiencing the problem?
Node.js
Node Version (if applicable)
None
Link To Reproduction
https://codesandbox.io/p/devbox/fabric-node-sandbox-forked-lyrkjc?workspaceId=015bad26-68eb-4698-a728-aa124cb65760
Steps To Reproduce
fabric.FabricImage.fromURL()
See the reproduction, or this image:
![image](https://private-user-images.githubusercontent.com/150863066/348364958-2c8cf452-dbe0-4241-a564-248973ea9ce4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTQ1NjAsIm5iZiI6MTczODg5NDI2MCwicGF0aCI6Ii8xNTA4NjMwNjYvMzQ4MzY0OTU4LTJjOGNmNDUyLWRiZTAtNDI0MS1hNTY0LTI0ODk3M2VhOWNlNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwMjExMDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNmI5Nzk1NzgzMGM0MGMyMGQwYzIwZjUyNDQzYjg4ZWU4MmM1NDM5NzYwY2ZiOGVmOTk0ZmIxN2Q4YzA3MGZjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.yvSZ_7hW4_Lf0D-1ADIPMPEnIXNH1cVNlGtrdtGN6iA)
Expected Behavior
I'd expect to get the "test2" log, which is within the callback.
Actual Behavior
I get "test1" and "test3" logs, but not the "test2" log.
Error Message & Stack Trace
# There is none (that in itself is an issue).
Additional Information
On my actual project I'm running v6.0.2, however that version isn't available on the dropdown when filling out the issue form (I just edited the message to change it from the highest version it would let me, "v6.0.1", to v6.0.2.
The text was updated successfully, but these errors were encountered: