Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependency declarations in kubernetes-model-generator #6327

Open
manusa opened this issue Sep 4, 2024 · 2 comments
Open
Assignees
Labels
component/kubernetes-model Deals with the kubernetes-model

Comments

@manusa
Copy link
Member

manusa commented Sep 4, 2024

Description

Part of #6130

The kubernetes-model-generator module kubernetes-model-generator/pom.xml file contains multiple dependency declarations that seem to be unused.

The following lines should be removed:

<dependencies>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>
<!-- CompileOnly (provided) dependencies -->
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
</dependency>
<dependency>
<groupId>io.sundr</groupId>
<artifactId>builder-annotations</artifactId>
</dependency>
<dependency>
<groupId>io.sundr</groupId>
<artifactId>transform-annotations</artifactId>
</dependency>
<dependency>
<groupId>io.sundr</groupId>
<artifactId>sundr-codegen-velocity-nodeps</artifactId>
</dependency>
<!-- Test dependencies -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>net.javacrumbs.json-unit</groupId>
<artifactId>json-unit-fluent</artifactId>
<version>2.38.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.17.0</version>
<scope>test</scope>
</dependency>
</dependencies>

@manusa manusa added the component/kubernetes-model Deals with the kubernetes-model label Sep 4, 2024
@vaidikcode
Copy link

@manusa Should I proceed with removing these dependencies? Will doing so interfere with the ongoing generator-related tasks?

@manusa
Copy link
Member Author

manusa commented Oct 28, 2024

You can try to remove these if you want. If the build passes, then it will be OK to merge.
Let me assign this issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kubernetes-model Deals with the kubernetes-model
Projects
None yet
Development

No branches or pull requests

2 participants