Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS update & review: ch 5 #394

Closed
mishaone opened this issue Jul 6, 2018 · 8 comments
Closed

GS update & review: ch 5 #394

mishaone opened this issue Jul 6, 2018 · 8 comments
Assignees
@Preeticp
Labels
Getting Started Guide SEV3 Please prioritize in your backlog at your discretion. task New content or other non-bug work.

Comments

@mishaone
Copy link
Contributor

mishaone commented Jul 6, 2018

This chapter includes 20 modules. Please review, improve the wording where required and test to ensure it's still up to date.
@mishaone mishaone added task New content or other non-bug work. Getting Started Guide SEV3 Please prioritize in your backlog at your discretion. labels Jul 6, 2018
@mishaone
Copy link
Contributor Author

mishaone commented Jul 6, 2018

I think the planning development work part in particular needs to be trimmed down and made specific to the relevant tasks for this example. If you'd like me to look into that one, I'm happy to swap out one of my modules, just to get someone else to look at it.

@Preeticp
Copy link
Collaborator

Preeticp commented Jul 6, 2018

Yes I think we agreed on it in our last discussion. How about I take a shot at it and get it reviewed by you and Robert? If you are still not satisfied maybe you can take over the module. Is that alright?

@mishaone
Copy link
Contributor Author

mishaone commented Jul 6, 2018

All good. I offered in case you were sick of looking at it and wanted someone else to do it instead. :)

@Preeticp
Copy link
Collaborator

Preeticp commented Jul 6, 2018

Got it :)

@Preeticp Preeticp added this to the Iteration 152, J train milestone Jul 9, 2018
@Preeticp Preeticp mentioned this issue Jul 27, 2018
Closed
@Preeticp
Copy link
Collaborator

1st PR

@mishaone
Copy link
Contributor Author

2nd PR: #408

(adding so that this turns up as work done this week for scrum of scrums

@Preeticp Preeticp removed this from the Iteration 152, J train milestone Aug 20, 2018
@Preeticp
Copy link
Collaborator

Preeticp commented Sep 3, 2018

3rd PR: #414

@Preeticp
Copy link
Collaborator

4th and final PR: #424
This completes the review and updates for Chpt 5.

@Preeticp Preeticp mentioned this issue Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Preeticp Preeticp

Labels
Getting Started Guide SEV3 Please prioritize in your backlog at your discretion. task New content or other non-bug work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mishaone @Preeticp