From dd963c5c5e5a44bda038f277e72b36b941da4f0c Mon Sep 17 00:00:00 2001 From: Michael Vorburger Date: Wed, 16 Jan 2019 04:09:29 +0100 Subject: [PATCH 1/2] test: allow additional parameters to test_app() --- test.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test.sh b/test.sh index 55c2f4b8..8cce90d6 100755 --- a/test.sh +++ b/test.sh @@ -6,8 +6,9 @@ set -ex function test_app() { local name=$1 local port="8080" + local extra_args=${2:-""} - local container_id=$(docker run --name ${name}-test -d -p ${port} ${name}) + local container_id=$(docker run --name ${name}-test -d -p ${port} ${extra_args} ${name}) # sleep is required because after docker run returns, the container is up but our server may not quite be yet sleep 5 From 72b93c56ae7af6ba8a7e827fa7437a2036548479 Mon Sep 17 00:00:00 2001 From: Michael Vorburger Date: Wed, 16 Jan 2019 04:13:05 +0100 Subject: [PATCH 2/2] test: add TDD non-reg illustrating #213 problem (failing) --- test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test.sh b/test.sh index 8cce90d6..10474824 100755 --- a/test.sh +++ b/test.sh @@ -86,6 +86,7 @@ function test_entrypoint() { function test_container() { test_app $1 + test_app $1 "-e JAVA_DIAGNOSTICS=TRUE" # https://github.com/fabric8io-images/s2i/issues/213 test_metrics $1 }